From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-acpi@vger.kernel.org,
Faouaz TENOUTIT <faouaz.tenoutit@intel.com>
Subject: Re: [PATCH v4 1/2] USB: Use ACPI device information
Date: Thu, 14 Aug 2014 08:45:32 +0800 [thread overview]
Message-ID: <20140814004532.GA26547@kroah.com> (raw)
In-Reply-To: <2225297.jp5n9UkMJt@vostro.rjw.lan>
On Thu, Aug 14, 2014 at 02:17:59AM +0200, Rafael J. Wysocki wrote:
> On Thursday, August 14, 2014 06:03:09 AM Greg Kroah-Hartman wrote:
> > On Wed, Aug 13, 2014 at 07:15:31PM +0200, Samuel Ortiz wrote:
> > > From: Faouaz TENOUTIT <faouaz.tenoutit@intel.com>
> > >
> > > Use ACPI device pld information instead of calling
> > > acpi_get_physical_device_location.
> >
> > Why? What does this do "better" than the existing code?
>
> Well, you've acked this patch before. :-)
I can't remember what I ate for Lunch yesterday, let alone previous
patches I've acked :)
> It just doesn't execute AML from within the USB core. I thought that would
> be a sufficient reason, wouldn't it?
Yes, that's fine, but a little more description of "why" would have been
helpful here...
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-14 0:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 17:15 [PATCH v4 1/2] USB: Use ACPI device information Samuel Ortiz
2014-08-13 17:15 ` [PATCH v4 2/2] ACPI: Export PLD (Physical Location of Device) Samuel Ortiz
2014-08-13 22:05 ` Greg Kroah-Hartman
2014-08-14 0:15 ` Rafael J. Wysocki
2014-08-14 0:46 ` Greg Kroah-Hartman
2014-08-13 22:03 ` [PATCH v4 1/2] USB: Use ACPI device information Greg Kroah-Hartman
2014-08-14 0:17 ` Rafael J. Wysocki
2014-08-14 0:45 ` Greg Kroah-Hartman [this message]
2014-08-15 0:03 ` Rafael J. Wysocki
2014-09-03 22:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814004532.GA26547@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=faouaz.tenoutit@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox