From: Mark Brown <broonie@kernel.org>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mark Rutland <mark.rutland@arm.com>,
Olof Johansson <olof@lixom.net>,
Grant Likely <grant.likely@linaro.org>,
Graeme Gregory <graeme.gregory@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Will Deacon <will.deacon@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh@kernel.org>, Robert Richter <rric@kernel.org>,
Lv Zheng <lv.zheng@intel.com>,
Robert Moore <robert.moore@intel.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Randy Dunlap <rdunlap@infradead.org>,
Charles.Garcia-Tobin@arm.com, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH for Juno 2/2] tty: SBSA compatible UART
Date: Mon, 1 Sep 2014 16:26:44 +0100 [thread overview]
Message-ID: <20140901152644.GC29327@sirena.org.uk> (raw)
In-Reply-To: <1409583961-7466-3-git-send-email-hanjun.guo@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Mon, Sep 01, 2014 at 11:06:01PM +0800, Hanjun Guo wrote:
> From: Graeme Gregory <graeme.gregory@linaro.org>
>
> This is a subset of pl011 UART which does not supprt DMA or baud rate
> changing.
>
> It is specified in the Server Base System Architecture document from
> ARM.
Is there any reason not to consider submitting this as a TTY driver now
- are there known problems other than the issues with ACPI in general
(I've not reviewed the code at all)? The ACPI binding in this case
seems particularly safe since it's a purposely basic and unconfigurable
IP.
I guess we may want to consider handoff to the full pl011 driver at some
point but there's a bunch of stuff with clocks to worry about before
then.
>
> Signed-off-by: Graeme Gregory <graeme.gregory@linaro.org>
> ---
Missing signoff here.
> +config SBSAUART_TTY
> + tristate "SBSA UART TTY Driver"
> + help
> + Console and system TTY driver for the SBSA UART which is defined
> + in the Server Base System Architecure document for ARM64 servers.
> +
depends on ARM || ARM64 || COMPILE_TEST?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-01 15:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:05 [RFC PATCH for Juno 0/2] Drivers for Juno to boot from ACPI Hanjun Guo
2014-09-01 15:06 ` [RFC PATCH for Juno 1/2] net: smsc911x add support for probing " Hanjun Guo
2014-09-01 15:17 ` [Linaro-acpi] " Arnd Bergmann
2014-09-01 15:28 ` Graeme Gregory
2014-09-01 15:32 ` Arnd Bergmann
2014-09-01 16:53 ` Catalin Marinas
2014-09-01 16:58 ` Mark Brown
2014-09-01 17:08 ` Sudeep Holla
2014-09-01 17:14 ` Catalin Marinas
2014-09-01 17:33 ` Sudeep Holla
2014-09-01 17:03 ` Graeme Gregory
2014-09-15 4:08 ` Grant Likely
2014-09-15 9:24 ` Catalin Marinas
2014-09-01 17:04 ` Catalin Marinas
2014-09-01 17:11 ` Arnd Bergmann
2014-09-01 17:27 ` Catalin Marinas
2014-09-01 17:32 ` Graeme Gregory
2014-09-01 18:11 ` Mark Brown
2014-09-02 13:26 ` Catalin Marinas
2014-09-02 13:42 ` [Linaro-acpi] " Arnd Bergmann
2014-09-02 16:26 ` Mark Brown
2014-09-02 23:00 ` Rafael J. Wysocki
2014-09-03 15:09 ` Arnd Bergmann
2014-09-09 6:51 ` Jon Masters
2014-09-15 4:14 ` Grant Likely
2014-09-15 16:12 ` Mark Brown
2014-09-01 15:06 ` [RFC PATCH for Juno 2/2] tty: SBSA compatible UART Hanjun Guo
2014-09-01 15:26 ` Mark Brown [this message]
2014-09-01 17:12 ` Catalin Marinas
2014-09-01 17:18 ` Graeme Gregory
2014-09-01 17:29 ` Catalin Marinas
2014-09-01 15:29 ` [RFC PATCH for Juno 0/2] Drivers for Juno to boot from ACPI Arnd Bergmann
2014-09-09 6:55 ` Jon Masters
2014-09-09 10:55 ` Arnd Bergmann
2014-09-09 14:13 ` Jon Masters
2014-09-15 22:57 ` Grant Likely
2014-09-15 23:00 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901152644.GC29327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Charles.Garcia-Tobin@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=grant.likely@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=robh@kernel.org \
--cc=rric@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox