From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v3 03/17] ARM64 / ACPI: Introduce lowlevel suspend function Date: Tue, 9 Sep 2014 17:35:29 +0100 Message-ID: <20140909163529.GA6370@arm.com> References: <1409583475-6978-1-git-send-email-hanjun.guo@linaro.org> <1409583475-6978-4-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:37392 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757157AbaIIQfn convert rfc822-to-8bit (ORCPT ); Tue, 9 Sep 2014 12:35:43 -0400 In-Reply-To: <1409583475-6978-4-git-send-email-hanjun.guo@linaro.org> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo Cc: "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , "grant.likely@linaro.org" , "graeme.gregory@linaro.org" , Arnd Bergmann , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" On Mon, Sep 01, 2014 at 03:57:41PM +0100, Hanjun Guo wrote: > From: Graeme Gregory > > acpi_wakeup_address is used on x86 as the address bios jumps into > when machine wakes up from suspend. As arm64 does not have such a > bios this mechanism will be provided by other means. But the define > is still required inside the acpi core. > > Introduce a null stub for acpi_suspend_lowlevel as this is also > required by core. This will be filled in when standards are > defined for arm64 ACPI global power states. Do we actually plan to use these on arm64? I'm worried most of these don't make sense on arm64 (the aim is to use PSCI). Is it possible to refactor the core code so that we don't have to define dummy macros or variables just to be able to build the kernel? -- Catalin