Re: [PATCH v4 06/18] ARM64 / ACPI: Introduce early_param for "acpi"

Olof Johansson
2014-09-15T17:08:49Z

On Mon, Sep 15, 2014 at 03:51:07PM +0100, Catalin Marinas wrote:
> On Mon, Sep 15, 2014 at 07:28:24AM +0100, Olof Johansson wrote:
> > On Fri, Sep 12, 2014 at 10:00:04PM +0800, Hanjun Guo wrote:
> > > See also Documentation/power/runtime_pm.txt, pci=noacpi
> > >
> > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
> > > index 9252f72..693da7f 100644
> > > --- a/arch/arm64/kernel/acpi.c
> > > +++ b/arch/arm64/kernel/acpi.c
> > > @@ -67,3 +67,18 @@ void __init acpi_boot_table_init(void)
> > > if (acpi_table_init())
> > > disable_acpi();
> > > }
> > > +
> > > +static int __init parse_acpi(char *arg)
> > > +{
> > > + if (!arg)
> > > + return -EINVAL;
> > > +
> > > + /* "acpi=off" disables both ACPI table parsing and interpreter */
> > > + if (strcmp(arg, "off") == 0)
> > > + disable_acpi();
> > > + else
> > > + return -EINVAL; /* Core will print when we return error */
> >
> > For symmetry, you should handle acpi=force here too (i.e. if someone
> > disables by default, which I expect we'll ask for when this code is
> > first merged).
>
> Does this mean you want another Kconfig option - ACPI_DEFAULT_OFF (which
> would be set by default)?

No, adding another config option isn't going to help anyone. Instead,
this gives us the full symmetry and option to just always by default
keep ACPI off, even if it is merged.

My argument on when ACPI should be merged is not new (i.e. once we've
seen more than just the simple system parts solved with it and solved
successfully), then we're still likely to have a transition period when
it's in tree but not enabled by default. That's what acpi=force is for,
for those who want to test with it during that time.

So, my suggestion is just there now to make sure that whichever way
we go, things will just work as expected (and the same way as on x86,
which is a goal for some).

-Olof