From: Mark Brown <broonie@kernel.org>
To: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux acpi <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Zheng, Lv" <lv.zheng@intel.com>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH v7 1/2] Mailbox: Add support for Platform Communication Channel
Date: Thu, 18 Sep 2014 10:35:45 -0700 [thread overview]
Message-ID: <20140918173545.GZ7960@sirena.org.uk> (raw)
In-Reply-To: <CAJ5Y-ebOd1wN+FFH4BSB7JgvEqLi_5fq_FFmVD_i50cpoWjKXQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Wed, Sep 17, 2014 at 06:17:03PM -0400, Ashwin Chaugule wrote:
> + while (!(readw_relaxed(&generic_comm_base->status) &
> PCC_CMD_COMPLETE)) {
> + if (retries++ < 5)
> + udelay(cmd_delay);
> + else {
> + pr_err("PCC platform did not respond.\n");
> + return false;
> + }
> + }
You should have { } on both branches of the if but otherwise that looks
fine to me (assuming that there are enough retries).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-23 0:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 17:20 [PATCH v7 0/2] PCC: Platform Communication Channel Ashwin Chaugule
2014-09-10 17:20 ` [PATCH v7 1/2] Mailbox: Add support for " Ashwin Chaugule
2014-09-12 13:08 ` Ashwin Chaugule
2014-09-13 15:57 ` Mark Brown
2014-09-13 22:05 ` Ashwin Chaugule
2014-09-16 4:38 ` Zheng, Lv
2014-09-16 18:24 ` Ashwin Chaugule
2014-09-16 17:40 ` Mark Brown
2014-09-16 18:28 ` Ashwin Chaugule
2014-09-17 22:17 ` Ashwin Chaugule
2014-09-18 17:35 ` Mark Brown [this message]
2014-09-30 17:23 ` Ashwin Chaugule
2014-10-01 16:00 ` Mark Brown
2014-09-10 17:20 ` [PATCH v7 2/2] PCC test Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918173545.GZ7960@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox