Re: [PATCH 2/4] ACPI / platform: provide default DMA mask

Rafael J. Wysocki
2014-09-23T14:32:16Z

On Tuesday, September 23, 2014 03:17:12 PM Heikki Krogerus wrote:
> On Wed, Aug 20, 2014 at 02:55:26PM +0300, Heikki Krogerus wrote:
> > Most devices are configured for 32-bit DMA addresses.
> > Setting the mask to 32-bit here removes the need for the
> > drivers to do it separately.
>
> Rafael, is this OK?

Fine by me, but it should go in via dwc3 I think.

> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > ---
> > drivers/acpi/acpi_platform.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> > index 2bf9082..8d099e6 100644
> > --- a/drivers/acpi/acpi_platform.c
> > +++ b/drivers/acpi/acpi_platform.c
> > @@ -16,6 +16,7 @@
> > #include <linux/err.h>
> > #include <linux/kernel.h>
> > #include <linux/module.h>
> > +#include <linux/dma-mapping.h>
> > #include <linux/platform_device.h>
> >
> > #include "internal.h"
> > @@ -102,6 +103,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
> > pdevinfo.res = resources;
> > pdevinfo.num_res = count;
> > pdevinfo.acpi_node.companion = adev;
> > + pdevinfo.dma_mask = DMA_BIT_MASK(32);
> > pdev = platform_device_register_full(&pdevinfo);
> > if (IS_ERR(pdev))
> > dev_err(&adev->dev, "platform device creation failed: %ld\n",
>
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.