From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH] dell-wmi: Fix access out of memory Date: Sun, 12 Oct 2014 15:32:38 -0700 Message-ID: <20141012223238.GA28031@vmdeb7> References: <1411996251-13455-1-git-send-email-pali.rohar@gmail.com> <3073358.myrKz9QbdW@vostro.rjw.lan> <55C20A75-AB0A-4A4E-9E91-3428B5F868BB@infradead.org> <201410121845.07303@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <201410121845.07303@pali> Sender: platform-driver-x86-owner@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: "Rafael J. Wysocki" , Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Sun, Oct 12, 2014 at 06:45:06PM +0200, Pali Roh=E1r wrote: > On Tuesday 30 September 2014 01:16:23 Darren Hart wrote: > > On September 29, 2014 4:26:03 PM PDT, "Rafael J. Wysocki"=20 > wrote: > > >On Monday, September 29, 2014 02:30:29 PM Darren Hart wrote: > > >> On Mon, Sep 29, 2014 at 03:10:51PM +0200, Pali Roh=E1r wrote: > > >> > Without this patch driver dell-wmi is trying to access > > >> > elements of > > > > > >dynamically > > > > > >> > allocated array without checking array size. This can > > >> > lead to > > > > > >memory corruption > > > > > >> > or kernel panic. This patch adds missing checks for array > > >> > size. > > >> >=20 > > >> > Signed-off-by: Pali Roh=E1r > > >>=20 > > >> Looks good to me. Rafael, any concerns? > > > > > >Not anything obvious. > >=20 > > Queued, thanks. > >=20 > > >> Cc: linux-acpi > > > > > >Thanks! > > > >=20 > Now I see that this patch is in linus tree. Can you sent it to=20 > stable trees too? Hi Pali, Please see Documentation/stable_kernel_rules.txt for details on how to = mark patches for stable when you submit them. Now that it is in mainline, th= e process is a bit more manual, you'll find instructions for how to go about that= in the same document. Thanks, --=20 Darren Hart Intel Open Source Technology Center