Re: [PATCH 05/13] misc: at25: Make use of device property API

Geert Uytterhoeven
2014-10-07T09:10:25Z

On Tue, Oct 7, 2014 at 2:14 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> @@ -301,35 +301,33 @@ static ssize_t at25_mem_write(struct memory_accessor *mem, const char *buf,
>
> /*-------------------------------------------------------------------------*/
>
> -static int at25_np_to_chip(struct device *dev,
> - struct device_node *np,
> - struct spi_eeprom *chip)
> +static int at25_fw_to_chip(struct device *dev, struct spi_eeprom *chip)
> {
> u32 val;
>
> memset(chip, 0, sizeof(*chip));
> - strncpy(chip->name, np->name, sizeof(chip->name));
> + strncpy(chip->name, "at25", sizeof(chip->name));

So this changes chip->name from "eeprom" (or whatever name the DTS
writer used; "eeprom" is the ePAPR-compliant name) to "at25"?

Note:The example in Documentation/devicetree/bindings/misc/at25.txt
uses "at25", not "eeprom".

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds