From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v6 04/12] misc: at25: Make use of device property API Date: Tue, 4 Nov 2014 18:07:35 +0200 Message-ID: <20141104160735.GO1618@lahna.fi.intel.com> References: <13750506.S2yVlRRDa2@vostro.rjw.lan> <20141104143801.GM1618@lahna.fi.intel.com> <4645043.WOkgNMSUuO@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4645043.WOkgNMSUuO-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: Grant Likely , Linux Kernel Mailing List , ACPI Devel Maling List , Greg Kroah-Hartman , Darren Hart , Aaron Lu , Arnd Bergmann , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu List-Id: linux-acpi@vger.kernel.org On Tue, Nov 04, 2014 at 05:19:02PM +0100, Rafael J. Wysocki wrote: > > > I think np->name is "at25" in this case? The binding file > > > Documentation/devicetree/bindings/misc/at25.txt also has the same name. > > > > > > Are you OK, if we add something like below to the changelog? > > > > > > In addition we hard-code the name of the chip to be "at25" for the > > > reason that there is no common mechanism to fetch name of the firmware > > > node. The only existing user (arch/arm/boot/dts/phy3250.dts) uses the > > > same name so it should continue to work. > > > > Yes. If somebody complains, then we can reinstate the previous > > behaviour, but assume it isn't necessary for now. > > OK, done in my tree. Thanks Rafael! -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html