From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Darren Hart <dvhart@linux.intel.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties
Date: Wed, 5 Nov 2014 11:16:22 +0200 [thread overview]
Message-ID: <20141105091622.GW1618@lahna.fi.intel.com> (raw)
In-Reply-To: <3196606.Sy6xFg88zg@vostro.rjw.lan>
On Tue, Nov 04, 2014 at 11:54:41PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Subject: ACPI / property: Drop size_prop from acpi_dev_get_property_reference()
>
> The size_prop argument of the recently added function
> acpi_dev_get_property_reference() is not used by the only current
> caller of that function and is very unlikely to be used at any time
> going forward.
>
> Namely, for a property whose value is a list of items each containing
> a references to a device object possibly accompanied by some integers,
> the number of items in the list can always be computed as the number
> of elements of type ACPI_TYPE_LOCAL_REFERENCE in the property package.
> Thus it should never be necessary to provide an additional "cells"
> property with a value equal to the number of items in that list.
>
> For this reason, drop the size_prop argument from
> acpi_dev_get_property_reference() and update its caller accordingly.
>
> Link: http://marc.info/?l=linux-kernel&m=141511255610556&w=2
> Suggested-by: Grant Likely <grant.likely@linaro.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Just pulled your latest bleeding-edge (including this patch) and it
still works fine with both Minnowboards. Feel free to add my:
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2014-11-05 9:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 11:15 [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties Mika Westerberg
2014-10-28 15:57 ` Darren Hart
2014-10-28 21:59 ` Rafael J. Wysocki
2014-10-29 7:41 ` Alexandre Courbot
2014-10-29 8:54 ` Mika Westerberg
2014-10-29 14:42 ` Rafael J. Wysocki
2014-10-29 14:51 ` Rafael J. Wysocki
2014-10-29 14:44 ` Mika Westerberg
2014-11-01 11:11 ` Grant Likely
2014-11-03 4:49 ` Darren Hart
2014-11-03 15:25 ` Rafael J. Wysocki
2014-11-03 21:52 ` Rafael J. Wysocki
2014-11-04 14:48 ` Grant Likely
2014-11-04 16:06 ` Rafael J. Wysocki
2014-11-04 22:54 ` Rafael J. Wysocki
2014-11-04 22:58 ` Grant Likely
2014-11-04 23:42 ` Darren Hart
2014-11-05 20:59 ` Rafael J. Wysocki
2014-11-05 20:53 ` Darren Hart
2014-11-05 9:16 ` Mika Westerberg [this message]
2014-11-05 21:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105091622.GW1618@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=dvhart@linux.intel.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox