From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties Date: Wed, 5 Nov 2014 11:16:22 +0200 Message-ID: <20141105091622.GW1618@lahna.fi.intel.com> References: <1414494927-204923-1-git-send-email-mika.westerberg@linux.intel.com> <2107668.8toVpPDgB1@vostro.rjw.lan> <3196606.Sy6xFg88zg@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3196606.Sy6xFg88zg@vostro.rjw.lan> Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Grant Likely , Darren Hart , Alexandre Courbot , Linus Walleij , Arnd Bergmann , ACPI Devel Mailing List , Linux Kernel Mailing List List-Id: linux-acpi@vger.kernel.org On Tue, Nov 04, 2014 at 11:54:41PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: ACPI / property: Drop size_prop from acpi_dev_get_property_reference() > > The size_prop argument of the recently added function > acpi_dev_get_property_reference() is not used by the only current > caller of that function and is very unlikely to be used at any time > going forward. > > Namely, for a property whose value is a list of items each containing > a references to a device object possibly accompanied by some integers, > the number of items in the list can always be computed as the number > of elements of type ACPI_TYPE_LOCAL_REFERENCE in the property package. > Thus it should never be necessary to provide an additional "cells" > property with a value equal to the number of items in that list. > > For this reason, drop the size_prop argument from > acpi_dev_get_property_reference() and update its caller accordingly. > > Link: http://marc.info/?l=linux-kernel&m=141511255610556&w=2 > Suggested-by: Grant Likely > Signed-off-by: Rafael J. Wysocki Just pulled your latest bleeding-edge (including this patch) and it still works fine with both Minnowboards. Feel free to add my: Acked-by: Mika Westerberg Tested-by: Mika Westerberg