From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 0/3] Support PMIC operation region for CrystalCove and XPower Date: Thu, 13 Nov 2014 10:41:26 +0000 Message-ID: <20141113104126.GM24004@x1> References: <1414735705-18366-1-git-send-email-aaron.lu@intel.com> <3052882.EdcZmghHR3@vostro.rjw.lan> <20141112094419.GC24004@x1> <1668657.Fqph6NyFNz@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1668657.Fqph6NyFNz-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: Aaron Lu , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jacob Pan List-Id: linux-acpi@vger.kernel.org On Thu, 13 Nov 2014, Rafael J. Wysocki wrote: > On Wednesday, November 12, 2014 09:44:19 AM Lee Jones wrote: > > On Wed, 12 Nov 2014, Rafael J. Wysocki wrote: > >=20 > > > On Tuesday, November 11, 2014 11:11:52 AM Lee Jones wrote: > > > > On Tue, 11 Nov 2014, Aaron Lu wrote: > > > >=20 > > > > > On 10/31/2014 02:08 PM, Aaron Lu wrote: > > > > > > On Intel Baytrail-T and Baytrail-T-CR platforms, there are = two customized > > > > > > ACPI operation regions defined for the Power Management Int= egrated Circuit > > > > > > device, one is for power resource handling and one is for t= hermal: sensor > > > > > > temperature reporting, trip point setting, etc. There are d= ifferent PMIC > > > > > > chips used on those platforms and though each has the same = two operation > > > > > > regions and functionality, their implementation is differen= t so every PMIC > > > > > > will need a driver. But since their functionality is simila= r, some common > > > > > > code is abstracted into the intel_soc_pmic_opregion.c. > > > > > >=20 > > > > > > The last version is posted here: > > > > > > https://lkml.org/lkml/2014/9/8/801 > > > > > >=20 > > > > > > Changes since then: > > > > > > 1 Move to drivers/acpi as discussed on the above thread; > > > > > > 2 Added support for XPower AXP288 PMIC operation region sup= port; > > > > > > 3 Since operation region handler can not be removed(at the = moment at least), > > > > > > use bool for the two operation region driver configs inst= ead of tristate; > > > > > > Another reason to do this is that, with Mika's MFD ACPI s= upport patch, all > > > > > > those MFD cell devices created will have the same modalia= s as their parent's > > > > > > so it doesn't make much sense to compile these drivers in= to modules. > > > > > >=20 > > > > > > Patch 1 applies on top of Rafael's pm-next branch, and then= patch 2 and > > > > > > patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch whe= re the PMIC > > > > > > driver XPower AXP288 and iio driver axp288_adc is located. > > > > >=20 > > > > > Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 b= ranch, it > > > > > would be easy to go through the mfd/ib-mfd-iio-3.19 branch. > > > > >=20 > > > > > Rafael, > > > > > Can I get your ACK for the three patches? > > > > >=20 > > > > > Lee, > > > > > Can you please take the series if Rafael gives it ack? > > > >=20 > > > > Yes, no problem. > > >=20 > > > Well, since the code is going to reside mostly in drivers/acpi, I= think I should > > > be applying the patches and from your response it looks like you = are fine with > > > them. Is that correct? > >=20 > > I read that this set has dependencies on patches which are already = in > > the MFD tree. If that's not the case please go ahead and apply the= m > > with my Ack for the MFD components. >=20 > I thought you had a branch that I could pull into my tree and apply t= he patches > on top of it. At least that was my understanding of the Aaron's mess= age, so > please let me know if that's not the case. That is absolutely the case. 'mfd/ib-mfd-iio-3.19' is good to go. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog