From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@linux.intel.com>,
"Li, Aubrey" <aubrey.li@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Kristen Carlson Accardi <kristen@linux.intel.com>,
John Stultz <john.stultz@linaro.org>,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks
Date: Thu, 12 Feb 2015 14:26:43 +0100 [thread overview]
Message-ID: <20150212132643.GY23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <2407992.WHaFxrNaoa@vostro.rjw.lan>
On Wed, Feb 11, 2015 at 05:04:17AM +0100, Rafael J. Wysocki wrote:
> @@ -131,28 +133,32 @@ static struct cpuidle_state nehalem_csta
> .flags = MWAIT2flg(0x00),
> .exit_latency = 3,
> .target_residency = 6,
> - .enter = &intel_idle },
> + .enter = &intel_idle,
> + .enter_freeze = intel_idle_freeze, },
> {
> .name = "C1E-NHM",
> .desc = "MWAIT 0x01",
> .flags = MWAIT2flg(0x01),
> .exit_latency = 10,
> .target_residency = 20,
> - .enter = &intel_idle },
> + .enter = &intel_idle,
> + .enter_freeze = intel_idle_freeze, },
> {
> .name = "C3-NHM",
> .desc = "MWAIT 0x10",
> .flags = MWAIT2flg(0x10) | CPUIDLE_FLAG_TLB_FLUSHED,
> .exit_latency = 20,
> .target_residency = 80,
> - .enter = &intel_idle },
> + .enter = &intel_idle,
> + .enter_freeze = intel_idle_freeze, },
> {
> .name = "C6-NHM",
> .desc = "MWAIT 0x20",
> .flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED,
> .exit_latency = 200,
> .target_residency = 800,
> - .enter = &intel_idle },
> + .enter = &intel_idle,
> + .enter_freeze = intel_idle_freeze, },
> {
> .enter = NULL }
> };
Why bother with enter_freeze() for any but the deepest state (C6 in this
case)?
Also, should we ignore things like intel_idle.max_cstate for this
selection?
next prev parent reply other threads:[~2015-02-12 13:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 4:00 [PATCH 0/6] PM / sleep: Support for quiescing timers during suspend-to-idle Rafael J. Wysocki
2015-02-11 4:01 ` [PATCH 1/6] PM / sleep: Re-implement suspend-to-idle handling Rafael J. Wysocki
2015-02-12 13:14 ` Peter Zijlstra
2015-02-12 16:18 ` Rafael J. Wysocki
2015-02-12 22:33 ` [Update][PATCH 1/6 v2] " Rafael J. Wysocki
2015-02-11 4:01 ` [PATCH 2/6] timekeeping: Pass readout base to update_fast_timekeeper() Rafael J. Wysocki
2015-02-13 0:29 ` John Stultz
2015-02-11 4:03 ` [PATCH 3/6] timekeeping: Make it safe to use the fast timekeeper while suspended Rafael J. Wysocki
2015-02-13 0:53 ` John Stultz
2015-02-13 2:03 ` Rafael J. Wysocki
2015-02-13 2:59 ` Travis
2015-02-13 9:03 ` John Stultz
2015-02-13 14:32 ` Rafael J. Wysocki
2015-02-14 17:30 ` John Stultz
2015-02-11 4:03 ` [PATCH 4/6] PM / sleep: Make it possible to quiesce timers during suspend-to-idle Rafael J. Wysocki
2015-02-12 13:24 ` Peter Zijlstra
2015-02-12 16:19 ` Rafael J. Wysocki
2015-02-12 22:36 ` [Update][PATCH 4/6 v2] " Rafael J. Wysocki
2015-02-11 4:04 ` [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks Rafael J. Wysocki
2015-02-12 13:26 ` Peter Zijlstra [this message]
2015-02-12 16:24 ` Rafael J. Wysocki
2015-02-12 16:25 ` Peter Zijlstra
2015-03-04 23:50 ` Li, Aubrey
2015-03-05 0:18 ` Rafael J. Wysocki
2015-03-05 0:09 ` Li, Aubrey
2015-02-11 4:04 ` [PATCH 6/6] ACPI / idle: Implement ->enter_freeze callback routine Rafael J. Wysocki
2015-02-13 8:13 ` [PATCH 0/6] PM / sleep: Support for quiescing timers during suspend-to-idle Peter Zijlstra
2015-02-13 14:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212132643.GY23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alan@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=kristen@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox