Re: [PATCH v6 04/22] power_supply: Move run-time configuration to separate structure

Jiri Kosina
2015-03-11T16:06:47Z

On Tue, 10 Mar 2015, Krzysztof Kozlowski wrote:

> Add new structure 'power_supply_config' for holding run-time
> initialization data like of_node, supplies and private driver data.
>
> The power_supply_register() function is changed so all power supply
> drivers need updating.
>
> When registering the power supply this new 'power_supply_config' should be
> used instead of directly initializing 'struct power_supply'. This allows
> changing the ownership of power_supply structure from driver to the
> power supply core in next patches.
>
> When a driver does not use of_node or supplies then it should use NULL
> as config. If driver uses of_node or supplies then it should allocate
> config on stack and initialize it with proper values.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> [for the nvec part]
> Reviewed-by: Marc Dietrich <marvin24@gmx.de>
>
> [for drivers/platform/x86/compal-laptop.c]
> Reviewed-by: Darren Hart <dvhart@linux.intel.com>

Reviewed-by: Jiri Kosina <jkosina@suse.cz>

for changes in drivers/hid/*

--
Jiri Kosina
SUSE Labs