From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / sleep: Drop acpi_suspend() which is not used
Date: Tue, 17 Mar 2015 14:24:14 +0000 [thread overview]
Message-ID: <20150317142414.GA16721@red-moon> (raw)
In-Reply-To: <1460987.2Zo06X0UeC@vostro.rjw.lan>
On Tue, Mar 17, 2015 at 02:29:23PM +0000, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The acpi_suspend() function has no callers, so drop it.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
> drivers/acpi/sleep.c | 15 ---------------
> drivers/acpi/sleep.h | 2 --
> 2 files changed, 17 deletions(-)
>
> Index: linux-pm/drivers/acpi/sleep.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/sleep.c
> +++ linux-pm/drivers/acpi/sleep.c
> @@ -806,21 +806,6 @@ static void acpi_sleep_hibernate_setup(v
> static inline void acpi_sleep_hibernate_setup(void) {}
> #endif /* !CONFIG_HIBERNATION */
>
> -int acpi_suspend(u32 acpi_state)
> -{
> - suspend_state_t states[] = {
> - [1] = PM_SUSPEND_STANDBY,
> - [3] = PM_SUSPEND_MEM,
> - [5] = PM_SUSPEND_MAX
> - };
> -
> - if (acpi_state < 6 && states[acpi_state])
> - return pm_suspend(states[acpi_state]);
> - if (acpi_state == 4)
> - return hibernate();
> - return -EINVAL;
> -}
> -
> static void acpi_power_off_prepare(void)
> {
> /* Prepare to power off the system */
> Index: linux-pm/drivers/acpi/sleep.h
> ===================================================================
> --- linux-pm.orig/drivers/acpi/sleep.h
> +++ linux-pm/drivers/acpi/sleep.h
> @@ -1,6 +1,4 @@
>
> -extern int acpi_suspend(u32 state);
> -
> extern void acpi_enable_wakeup_devices(u8 sleep_state);
> extern void acpi_disable_wakeup_devices(u8 sleep_state);
>
>
>
>
next prev parent reply other threads:[~2015-03-17 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 8:14 [update][PATCH v10 06/21] ACPI / sleep: Introduce CONFIG_ACPI_GENERIC_SLEEP Hanjun Guo
2015-03-13 21:49 ` Rafael J. Wysocki
2015-03-16 12:14 ` Hanjun Guo
2015-03-16 23:15 ` Rafael J. Wysocki
2015-03-17 1:08 ` Hanjun Guo
2015-03-17 2:28 ` Rafael J. Wysocki
2015-03-17 2:36 ` Hanjun Guo
2015-03-17 3:23 ` Rafael J. Wysocki
2015-03-17 4:10 ` Hanjun Guo
2015-03-17 5:59 ` Jon Masters
2015-03-17 6:31 ` Hanjun Guo
2015-03-17 14:33 ` Rafael J. Wysocki
2015-03-18 1:56 ` Hanjun Guo
2015-03-17 12:35 ` Lorenzo Pieralisi
[not found] ` <CAGHbJ3DhUB688K7ooT7ai=2QjRp7S+_E_Y+a+GupeTvjR5omMg@mail.gmail.com>
2015-03-17 14:29 ` [PATCH] ACPI / sleep: Drop acpi_suspend() which is not used Rafael J. Wysocki
2015-03-17 14:24 ` Lorenzo Pieralisi [this message]
2015-03-18 1:17 ` Hanjun Guo
2015-03-17 14:30 ` [update][PATCH v10 06/21] ACPI / sleep: Introduce CONFIG_ACPI_GENERIC_SLEEP Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317142414.GA16721@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=hanjun.guo@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).