From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH] ACPI / sleep: Drop acpi_suspend() which is not used Date: Tue, 17 Mar 2015 14:24:14 +0000 Message-ID: <20150317142414.GA16721@red-moon> References: <1426234469-6434-1-git-send-email-hanjun.guo@linaro.org> <20150317123536.GB14984@red-moon> <1460987.2Zo06X0UeC@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from foss.arm.com ([217.140.101.70]:59089 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859AbbCQOYN (ORCPT ); Tue, 17 Mar 2015 10:24:13 -0400 Content-Disposition: inline In-Reply-To: <1460987.2Zo06X0UeC@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , "hanjun.guo@linaro.org" , Linux Kernel Mailing List On Tue, Mar 17, 2015 at 02:29:23PM +0000, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The acpi_suspend() function has no callers, so drop it. > > Signed-off-by: Rafael J. Wysocki Acked-by: Lorenzo Pieralisi > --- > drivers/acpi/sleep.c | 15 --------------- > drivers/acpi/sleep.h | 2 -- > 2 files changed, 17 deletions(-) > > Index: linux-pm/drivers/acpi/sleep.c > =================================================================== > --- linux-pm.orig/drivers/acpi/sleep.c > +++ linux-pm/drivers/acpi/sleep.c > @@ -806,21 +806,6 @@ static void acpi_sleep_hibernate_setup(v > static inline void acpi_sleep_hibernate_setup(void) {} > #endif /* !CONFIG_HIBERNATION */ > > -int acpi_suspend(u32 acpi_state) > -{ > - suspend_state_t states[] = { > - [1] = PM_SUSPEND_STANDBY, > - [3] = PM_SUSPEND_MEM, > - [5] = PM_SUSPEND_MAX > - }; > - > - if (acpi_state < 6 && states[acpi_state]) > - return pm_suspend(states[acpi_state]); > - if (acpi_state == 4) > - return hibernate(); > - return -EINVAL; > -} > - > static void acpi_power_off_prepare(void) > { > /* Prepare to power off the system */ > Index: linux-pm/drivers/acpi/sleep.h > =================================================================== > --- linux-pm.orig/drivers/acpi/sleep.h > +++ linux-pm/drivers/acpi/sleep.h > @@ -1,6 +1,4 @@ > > -extern int acpi_suspend(u32 state); > - > extern void acpi_enable_wakeup_devices(u8 sleep_state); > extern void acpi_disable_wakeup_devices(u8 sleep_state); > > > >