* [PATCH] ACPI SBS: Re-enable battery manager
@ 2015-04-22 15:40 Chris Bainbridge
2015-04-29 0:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Chris Bainbridge @ 2015-04-22 15:40 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown; +Cc: linux-acpi
Commit 9faf6136 introduced a regression disabling the SBS battery
manager. The battery manager should be marked as present when
acpi_manager_get_info returns 0.
Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com>
---
drivers/acpi/sbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index cd82762..01504c8 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -684,7 +684,7 @@ static int acpi_sbs_add(struct acpi_device *device)
if (!sbs_manager_broken) {
result = acpi_manager_get_info(sbs);
if (!result) {
- sbs->manager_present = 0;
+ sbs->manager_present = 1;
for (id = 0; id < MAX_SBS_BAT; ++id)
if ((sbs->batteries_supported & (1 << id)))
acpi_battery_add(sbs, id);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI SBS: Re-enable battery manager
2015-04-22 15:40 [PATCH] ACPI SBS: Re-enable battery manager Chris Bainbridge
@ 2015-04-29 0:38 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-04-29 0:38 UTC (permalink / raw)
To: Chris Bainbridge; +Cc: Len Brown, linux-acpi
On Wednesday, April 22, 2015 04:40:21 PM Chris Bainbridge wrote:
> Commit 9faf6136 introduced a regression disabling the SBS battery
> manager. The battery manager should be marked as present when
> acpi_manager_get_info returns 0.
>
> Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com>
Applied, thanks!
> ---
> drivers/acpi/sbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
> index cd82762..01504c8 100644
> --- a/drivers/acpi/sbs.c
> +++ b/drivers/acpi/sbs.c
> @@ -684,7 +684,7 @@ static int acpi_sbs_add(struct acpi_device *device)
> if (!sbs_manager_broken) {
> result = acpi_manager_get_info(sbs);
> if (!result) {
> - sbs->manager_present = 0;
> + sbs->manager_present = 1;
> for (id = 0; id < MAX_SBS_BAT; ++id)
> if ((sbs->batteries_supported & (1 << id)))
> acpi_battery_add(sbs, id);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-29 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-22 15:40 [PATCH] ACPI SBS: Re-enable battery manager Chris Bainbridge
2015-04-29 0:38 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).