From: Ingo Molnar <mingo@kernel.org>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Neil Brown <neilb@suse.de>, Greg KH <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dave Chinner <david@fromorbit.com>,
Robert Moore <robert.moore@intel.com>,
Andy Lutomirski <luto@amacapital.net>, Jens Axboe <axboe@fb.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Christoph Hellwig <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
Date: Thu, 23 Apr 2015 07:43:27 +0200 [thread overview]
Message-ID: <20150423054327.GA28898@gmail.com> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295A8BE846@G9W0745.americas.hpqcorp.net>
* Elliott, Robert (Server Storage) <Elliott@hp.com> wrote:
> > -----Original Message-----
> > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of
> > Dan Williams
> > Sent: Friday, April 17, 2015 8:35 PM
> > To: linux-nvdimm@lists.01.org
> > Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
> >
> ...
> > create mode 100644 drivers/block/nd/acpi.c
> > create mode 100644 drivers/block/nd/blk.c
> > create mode 100644 drivers/block/nd/bus.c
> > create mode 100644 drivers/block/nd/core.c
> ...
>
> The kernel already has lots of files with these names:
> 5 acpi.c
> 10 bus.c
> 66 core.c
>
> I often use ctags like this:
> vim -t core.c
> but that doesn’t immediately work with common filenames - it
> presents a list of all 66 files to choose from.
>
> Also, blk.c is a name one might expect to see in the block/
> directory (e.g., next to blk.h).
>
> An nd_ prefix on all the filenames would help.
It's really stupid to duplicate information that is present in the
pathname.
To type:
vim -t nd/core.c
should be the same as:
vim -t nd_core.c
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-04-23 5:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 1:35 [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem Dan Williams
2015-04-18 1:35 ` [PATCH 03/21] nd_acpi: initial core implementation and nfit skeleton Dan Williams
2015-04-18 19:41 ` Paul Bolle
2015-04-19 19:12 ` Rafael J. Wysocki
2015-04-28 12:53 ` [Linux-nvdimm] " Christoph Hellwig
2015-04-28 19:21 ` Dan Williams
2015-04-18 1:35 ` [PATCH 08/21] nd: ndctl.h, the nd ioctl abi Dan Williams
2015-04-21 21:20 ` [Linux-nvdimm] " Toshi Kani
2015-04-21 22:05 ` Dan Williams
2015-04-21 22:16 ` Toshi Kani
2015-04-24 15:56 ` Toshi Kani
2015-04-24 16:09 ` Toshi Kani
2015-04-24 16:31 ` Dan Williams
2015-04-24 16:25 ` Dan Williams
2015-04-24 17:18 ` Toshi Kani
2015-04-24 17:45 ` Dan Williams
2015-04-25 0:35 ` Toshi Kani
2015-04-18 19:29 ` [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem Dan Williams
2015-04-22 19:06 ` [Linux-nvdimm] " Elliott, Robert (Server Storage)
2015-04-22 19:39 ` Dan Williams
2015-04-23 5:43 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423054327.GA28898@gmail.com \
--to=mingo@kernel.org \
--cc=Elliott@hp.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=luto@amacapital.net \
--cc=neilb@suse.de \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).