Re: Patch breaks suspend

[Aaron Lu <aaron.lu@intel.com>]

On Tue, May 05, 2015 at 01:37:33AM +0200, Rafael J. Wysocki wrote:
> On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote:
> > Hi guys,
> > I have Lenovo T520 with one SSD and one SATA drive.
> > 
> > I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.

Is it disappeared after resume?

> > Both drives have bios encryption enabled.
> > 
> > I did a bisect and found that the following patch causes the issue:
> > commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
> > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Date:   Sat Feb 22 00:48:31 2014 +0100
> > 
> >     ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
> >    
> >     Modify the SATA subsystem to add hotplug contexts to ACPI companions
> >     of SATA devices and ports instead of registering special ACPI dock
> >     operations using register_hotplug_dock_device().
> >    
> >     That change will allow the entire code handling those special ACPI
> >     dock operations to be dropped in the next commit.
> >    
> >     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >     Reviewed-by: Aaron Lu <aaron.lu@intel.com>
> >     Acked-by: Tejun Heo <tj@kernel.org>
> > 
> > Unfortunately I do not understand this part of the code and have no idea what I can do.
> > Any pointers would be very appreciated.
> 
> Well, not right from the top of my head, but this looks really suspicious to me.
> 
> Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS
> category), assign it to me and CC Aaron?

Please attach dmesg, lspci and acpidump there when filing the bug, thanks.

BTW, this commit has been in upstream since v3.15, is your last kernel
in use older than v3.15?

Thanks,
Aaron