From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [Linux-nvdimm] [PATCH v2 00/20] libnd: non-volatile memory device support Date: Thu, 7 May 2015 09:29:13 +0200 Message-ID: <20150507072913.GB23239@lst.de> References: <20150428181203.35812.60474.stgit@dwillia2-desk3.amr.corp.intel.com> <94D0CD8314A33A4D9D801C0FE68B40295A8C934B@G9W0745.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:52630 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbEGH3P (ORCPT ); Thu, 7 May 2015 03:29:15 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dan Williams Cc: "Elliott, Robert (Server Storage)" , "linux-nvdimm@lists.01.org" , Neil Brown , Dave Chinner , "H. Peter Anvin" , Christoph Hellwig , "Wysocki, Rafael J" , "Moore, Robert" , Ingo Molnar , "linux-acpi@vger.kernel.org" , Jens Axboe , Borislav Petkov , Thomas Gleixner , Greg KH , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Andrew Morton , Linus Torvalds On Tue, Apr 28, 2015 at 03:15:54PM -0700, Dan Williams wrote: > > lsblk's blkdev_scsi_type_to_name() considers 4 to mean > > SCSI_TYPE_WORM (write once read many ... used for certain optical > > and tape drives). > > Why is lsblk assuming these are scsi devices? I'll need to go check that out. It's a very common assumption unfortunately. I rember fixing it in various in-house tools at customers and stumbled over it in targetcli recently. Please use a prefix for your type attribute to avoid this problem.