From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory Date: Sat, 13 Jun 2015 10:27:51 +0200 Message-ID: <20150613082750.GA3470@pd.tnic> References: <1434047160-23358-1-git-send-email-zjzhang@codeaurora.org> <1434047160-23358-5-git-send-email-zjzhang@codeaurora.org> <20150612162924.GH9084@pd.tnic> <557B6ED9.3020706@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:55735 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbFMI1x (ORCPT ); Sat, 13 Jun 2015 04:27:53 -0400 Content-Disposition: inline In-Reply-To: <557B6ED9.3020706@codeaurora.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Zhang, Jonathan Zhixiong" Cc: Matt Fleming , Thomas Gleixner , fu.wei@linaro.org, al.stone@linaro.org, tony.luck@gmail.com, rjw@rjwysocki.net, lenb@kernel.org, ying.huang@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 04:44:25PM -0700, Zhang, Jonathan Zhixiong wrote: > Since such function is only needed for APEI functionality, at least as > of today, I will name it arch_apei_get_mem_attribute(). Why? It can be extended to be used generically too, no? Come to think of it, the different arches should already have a way to tell you with what mem attributes a physical address is mapped, no? IOW, such functionality should be already present, you'd only have to find it and use it. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --