From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 12/15] libnvdimm: enable iostat Date: Sun, 21 Jun 2015 12:11:18 +0200 Message-ID: <20150621101118.GE5915@lst.de> References: <20150617235209.12943.24419.stgit@dwillia2-desk3.amr.corp.intel.com> <20150617235551.12943.76656.stgit@dwillia2-desk3.amr.corp.intel.com> <20150619083410.GA2885@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org To: Dan Williams Cc: Christoph Hellwig , Jens Axboe , "linux-nvdimm@lists.01.org" , Boaz Harrosh , "Kani, Toshimitsu" , Vishal Verma , "linux-kernel@vger.kernel.org" , Linux ACPI , linux-fsdevel , Ingo Molnar List-Id: linux-acpi@vger.kernel.org On Fri, Jun 19, 2015 at 02:02:39AM -0700, Dan Williams wrote: > On Fri, Jun 19, 2015 at 1:34 AM, Christoph Hellwig wrote: > > On Wed, Jun 17, 2015 at 07:55:51PM -0400, Dan Williams wrote: > >> This is disabled by default as the overhead is prohibitive, but if the > >> user takes the action to turn it on we'll oblige. > > > > If you care about users a compile time selection doesn't make sense, > > why not always build it but require an opt-in? > > It's always built the Kconfig just selects the default initial state > of QUEUE_FLAG_IO_STAT. They can always turn it on/off via block queue > sysfs. Oh, missed that. Just drop the Kconfig option in that case. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in