Re: [PATCH 12/15] libnvdimm: enable iostat

Christoph Hellwig
2015-06-21T10:11:18Z

On Fri, Jun 19, 2015 at 02:02:39AM -0700, Dan Williams wrote:
> On Fri, Jun 19, 2015 at 1:34 AM, Christoph Hellwig <hch@lst.de> wrote:
> > On Wed, Jun 17, 2015 at 07:55:51PM -0400, Dan Williams wrote:
> >> This is disabled by default as the overhead is prohibitive, but if the
> >> user takes the action to turn it on we'll oblige.
> >
> > If you care about users a compile time selection doesn't make sense,
> > why not always build it but require an opt-in?
>
> It's always built the Kconfig just selects the default initial state
> of QUEUE_FLAG_IO_STAT. They can always turn it on/off via block queue
> sysfs.

Oh, missed that. Just drop the Kconfig option in that case.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in