From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [PATCH] thermal: consistently use int for temperatures Date: Mon, 06 Jul 2015 12:26:40 +0200 Message-ID: <20150706122640.2a61ca05@amdc2363> References: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:39432 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbGFK0x convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2015 06:26:53 -0400 In-reply-to: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Jean Delvare , Peter Feuerer , Heiko Stuebner , Stephen Warren , Thierry Reding , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Guenter Roeck , "Rafael J. Wysocki" , Maxime Ripard , Darren Hart , lm-sensors@lm-sensors.org Hi Sascha, > The thermal code uses int, long and unsigned long for temperatures > in different places. >=20 > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for temperatures below 0=C2=B0C. This will > probably immediately shut the machine down due to overtemperature if > started below 0=C2=B0C. >=20 > 'long' is 64bit on several architectures. This is not needed since > INT_MAX =C2=B0mC is above the melting point of all known materials. >=20 > Consistently use a plain 'int' for temperatures throughout the > thermal code and the drivers. This only changes the places in the > drivers where the temperature is passed around as pointer, when > drivers internally use another type this is not changed. >=20 > Signed-off-by: Sascha Hauer Sascha, thanks for this cleanup work.=20 Reviewed-by: Lukasz Majewski --=20 Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html