public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Vinod Koul <vinod.koul@intel.com>,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	mturquette@baylibre.com, sboyd@codeaurora.org
Subject: Re: [PATCH v6 0/8] mfd: introduce a driver for LPSS devices on SPT
Date: Mon, 27 Jul 2015 19:04:47 +0300	[thread overview]
Message-ID: <20150727160447.GL1577@lahna.fi.intel.com> (raw)
In-Reply-To: <20150727152733.GB21114@x1>

On Mon, Jul 27, 2015 at 04:27:33PM +0100, Lee Jones wrote:
> FAO Stephen Boyd,
> 
> > Stephen, can you, please, have a look into patch 8 regarding to clock name
> > matching and other stuff Lee asked?
> 
> Patch 8:
> 
>       "Can you review the clock implementation please?  It looks
>       fragile to me as it relies heavily on device names constructed
>       of MFD cell names and IDA numbers cat'ed together!"

Lee, can you suggest an alternative then?

Why we are doing it like this is that number of different LPSS devices
changes from SoC to SoC. In addition to that the device (called "slice")
might have iDMA block or not.

Since the drivers in question (pxa2xx-spi, i2c-designware and 8250_dw)
use standard clk framework to request their clocks the Linux device must
have clock registered which matches the device in advance.

Because we add the host controller device dynamically (from the MFD
driver) based on how many devices are actually present, we need somehow
predict what would be the correct name and instance number for that
device to get the clock for it. That's the reason we use IDA here along
with the cell name (or driver name).

  reply	other threads:[~2015-07-27 16:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 15:03 [PATCH v6 0/8] mfd: introduce a driver for LPSS devices on SPT Andy Shevchenko
2015-07-27 15:03 ` [PATCH v6 1/8] PM / QoS: Make it possible to expose device latency tolerance to userspace Andy Shevchenko
2015-07-28  7:47   ` Lee Jones
2015-07-27 15:03 ` [PATCH v6 2/8] ACPI / PM: Attach ACPI power domain only once Andy Shevchenko
2015-07-28  7:47   ` Lee Jones
2015-07-27 15:03 ` [PATCH v6 3/8] Driver core: wakeup the parent device before trying probe Andy Shevchenko
2015-07-28  7:47   ` Lee Jones
2015-07-27 15:03 ` [PATCH v6 4/8] klist: implement klist_prev() Andy Shevchenko
2015-07-28  7:47   ` Lee Jones
2015-07-27 15:04 ` [PATCH v6 5/8] driver core: implement device_for_each_child_reverse() Andy Shevchenko
2015-07-28  7:48   ` Lee Jones
2015-07-27 15:04 ` [PATCH v6 6/8] mfd: make mfd_remove_devices() iterate in reverse order Andy Shevchenko
2015-07-28  7:48   ` Lee Jones
2015-07-27 15:04 ` [PATCH v6 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit Andy Shevchenko
2015-07-28  7:48   ` Lee Jones
2015-07-28  7:53     ` Lee Jones
2015-07-28  8:14       ` Andy Shevchenko
2015-07-28  8:43   ` Vinod Koul
2015-07-27 15:04 ` [PATCH v6 8/8] mfd: Add support for Intel Sunrisepoint LPSS devices Andy Shevchenko
2015-07-28  7:48   ` Lee Jones
2015-07-29 22:44   ` Michael Turquette
2015-07-29 23:30     ` Rafael J. Wysocki
2015-07-30 10:19     ` Andy Shevchenko
2015-07-27 15:27 ` [PATCH v6 0/8] mfd: introduce a driver for LPSS devices on SPT Lee Jones
2015-07-27 16:04   ` Mika Westerberg [this message]
2015-07-27 16:24     ` Lee Jones
2015-07-27 21:48       ` Rafael J. Wysocki
2015-07-27 21:27         ` Lee Jones
2015-07-27 21:29           ` Lee Jones
2015-07-27 22:03             ` Rafael J. Wysocki
2015-07-28  7:46               ` Lee Jones
2015-07-28  8:59 ` Lee Jones
2015-07-28  9:00   ` [GIT PULL] mfd: Immutable branch between MFD, Base, ACPI and DMA Lee Jones
2015-07-28  9:02   ` [PATCH v6 0/8] mfd: introduce a driver for LPSS devices on SPT Mika Westerberg
2015-07-29  0:30   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150727160447.GL1577@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sboyd@codeaurora.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox