Re: [PATCH v6 6/8] mfd: make mfd_remove_devices() iterate in reverse order

Lee Jones
2015-07-28T07:48:21Z

On Mon, 27 Jul 2015, Andy Shevchenko wrote:

> The newly introduced device_for_each_child_reverse() would be used when MFD
> core removes the device.
>
> After this patch applied the devices will be removed in a reversed order. This
> behaviour is useful when devices have implicit dependency on order, i.e.
> consider MFD device with serial bus controller, such as SPI, and DMA IP that is
> attached to serial bus controller: before remove the DMA driver we have to be
> ensured that no DMA transfers is ongoing and the requested channel are unused.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/mfd-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks. Pull request to follow.

> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 14fd5cb..c17635d 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -302,7 +302,7 @@ void mfd_remove_devices(struct device *parent)
> {
> atomic_t *cnts = NULL;
>
> - device_for_each_child(parent, &cnts, mfd_remove_devices_fn);
> + device_for_each_child_reverse(parent, &cnts, mfd_remove_devices_fn);
> kfree(cnts);
> }
> EXPORT_SYMBOL(mfd_remove_devices);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html