From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH V9 0/5] map GHES memory region according to EFI memory map Date: Wed, 5 Aug 2015 17:13:25 +0100 Message-ID: <20150805161325.GF4332@codeblueprint.co.uk> References: <1438292109-4170-1-git-send-email-zjzhang@codeaurora.org> <20150803112658.GE10501@arm.com> <20150803162354.GQ2725@codeblueprint.co.uk> <20150804042552.GG31787@nazgul.tnic> <55C0DD30.9070800@codeaurora.org> <20150805092125.GB4332@codeblueprint.co.uk> <55C232BC.1010107@codeaurora.org> <20150805161000.GE4332@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wi0-f181.google.com ([209.85.212.181]:36072 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbbHEQN2 (ORCPT ); Wed, 5 Aug 2015 12:13:28 -0400 Received: by wicgj17 with SMTP id gj17so199248388wic.1 for ; Wed, 05 Aug 2015 09:13:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150805161000.GE4332@codeblueprint.co.uk> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Zhang, Jonathan Zhixiong" Cc: Borislav Petkov , Will Deacon , Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "tony.luck@gmail.com" , "ard.biesheuvel@linaro.org" , "fu.wei@linaro.org" , "al.stone@linaro.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "ying.huang@intel.com" , Catalin Marinas , "leif.lindholm@linaro.org" , "hanjun.guo@linaro.org" , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" On Wed, 05 Aug, at 05:10:00PM, Matt Fleming wrote: > On Wed, 05 Aug, at 08:58:52AM, Zhang, Jonathan Zhixiong wrote: > > > > Yes, absolutely. It has been in my mind, sorry I was tied up in the last > > few days. I wonder what I may missed, I certainly do x86 build test with > > versions of the patch set. > > > > I will try today and report back. > > No problem. > > I'd suggest moving the implementation into include/acpi/apei.h and > leaving it as static inline instead of implementing it out of line in > arch/x86/kernel/acpi/apei.c. Yeah, I didn't mean include/acpi/apei.h but the architecture-specific equivalent. -- Matt Fleming, Intel Open Source Technology Center