Re: [PATCH V3 2/2] debugfs: don't assume sizeof(bool) to be 4 bytes

Steven Rostedt
2015-09-15T14:04:54Z

On Tue, 15 Sep 2015 14:04:59 +0530
Viresh Kumar <viresh.kumar@linaro.org> wrote:

> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 2614a839c60d..f11e17ad7834 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1237,7 +1237,7 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
> /* Use the global lock for all EC transactions? */
> tmp = 0;
> acpi_evaluate_integer(handle, "_GLK", NULL, &tmp);
> - ec->global_lock = tmp;
> + ec->global_lock = !!tmp;

BTW, the above is equivalent if global_lock is of type bool.

-- Steve

> ec->handle = handle;
> return AE_CTRL_TERMINATE;
> }
> diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
> index 9db196de003c..5a72e2b140fc 100644
> --- a/drivers/acpi/internal.h
> +++ b/drivers/acpi/internal.h
> @@ -138,7 +138,7 @@ struct acpi_ec {
> unsigned long gpe;
> unsigned long command_addr;
> unsigned long data_addr;
> - u32 global_lock;
> + bool global_lock;
> unsigned long flags;
> unsigned long reference_count;
> struct mutex mutex;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org