From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: gregkh@linuxfoundation.org, linaro-kernel@lists.linaro.org,
sboyd@codeaurora.org, arnd@arndb.de, stable@vger.kernel.org,
Len Brown <lenb@kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'
Date: Thu, 24 Sep 2015 17:03:02 -0700 [thread overview]
Message-ID: <20150925000302.GD5951@linux> (raw)
In-Reply-To: <1801121.8kgxqyHjgV@vostro.rjw.lan>
On 25-09-15, 02:17, Rafael J. Wysocki wrote:
> Actually, what about adding a local u32 variable, say val, here and doing
>
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
>
> if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, &val))
>
> > goto error;
>
> first_ec->global_lock = val;
>
> And then you can turn val into bool just fine without changing the structure
> definition.
sure. Looks good.
--
viresh
prev parent reply other threads:[~2015-09-25 0:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 8:34 [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock' Viresh Kumar
[not found] ` <9b705747a138c96c26faee5218f7b47403195b28.1442305897.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-15 8:34 ` [PATCH V3 2/2] debugfs: don't assume sizeof(bool) to be 4 bytes Viresh Kumar
2015-09-15 9:13 ` Charles Keepax
[not found] ` <27d37898b4be6b9b9f31b90135f8206ca079a868.1442305897.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-15 10:37 ` Johannes Berg
[not found] ` <1442313464.1914.21.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-09-15 11:04 ` Viresh Kumar
2015-09-15 13:45 ` Steven Rostedt
2015-09-15 14:04 ` Viresh Kumar
[not found] ` <20150915094509.46cca84d-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-09-15 17:38 ` Linus Torvalds
2015-09-15 17:47 ` Steven Rostedt
2015-09-16 7:24 ` Borislav Petkov
2015-09-16 8:02 ` Ingo Molnar
2015-09-15 14:04 ` Steven Rostedt
2015-09-15 14:12 ` Viresh Kumar
2015-09-15 14:29 ` Tejun Heo
2015-09-16 1:57 ` [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock' Rafael J. Wysocki
2015-09-16 2:06 ` Rafael J. Wysocki
2015-09-16 1:59 ` Viresh Kumar
2015-09-23 7:52 ` Zheng, Lv
2015-09-24 23:37 ` Viresh Kumar
2015-09-23 9:15 ` Sudeep Holla
2015-09-23 9:39 ` Arnd Bergmann
2015-09-23 9:57 ` Sudeep Holla
2015-09-23 10:29 ` Arnd Bergmann
2015-09-25 0:17 ` Rafael J. Wysocki
2015-09-25 0:03 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925000302.GD5951@linux \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).