From: Peter Zijlstra <peterz@infradead.org>
To: Chris Bainbridge <chris.bainbridge@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
lv.zheng@intel.com, mingo@redhat.com, rjw@rjwysocki.net,
oleg@redhat.com, aystarik@gmail.com
Subject: Re: [PATCH] Preserve task state in reentrant calls to ___wait_event
Date: Sat, 7 Nov 2015 10:19:54 +0100 [thread overview]
Message-ID: <20151107091954.GE17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151106204408.GA11609@localhost>
On Fri, Nov 06, 2015 at 08:44:08PM +0000, Chris Bainbridge wrote:
> I am assuming here that wait_event_timeout() is supposed to support reentrant
> calls.
Not really. It is sort of allowed, provided the inner one will rarely
block. And therefore the outer one will mostly work.
> If not, perhaps it should BUG_ON when called with a non-running task
> state,
There is a warning in __might_sleep() that catches some of this.
> and the SBS HC / ACPI EC code needs to be fixed to stop doing this.
Yes.
prev parent reply other threads:[~2015-11-07 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 20:44 [PATCH] Preserve task state in reentrant calls to ___wait_event Chris Bainbridge
2015-11-06 23:06 ` Rafael J. Wysocki
2015-11-12 18:05 ` [PATCH] ACPI / SMBus: Fix boot stalls / high CPU caused by reentrant code Chris Bainbridge
2015-11-12 19:24 ` [PATCH] Revert "ACPI / SBS: Add 5 us delay to fix SBS hangs on MacBook" Chris Bainbridge
2015-11-07 8:32 ` [PATCH] Preserve task state in reentrant calls to ___wait_event Chris Bainbridge
2015-11-07 9:19 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151107091954.GE17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aystarik@gmail.com \
--cc=chris.bainbridge@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox