From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties Date: Wed, 25 Nov 2015 14:12:52 +0200 Message-ID: <20151125121252.GY1587@lahna.fi.intel.com> References: <1448360579-79260-1-git-send-email-andriy.shevchenko@linux.intel.com> <1448360579-79260-12-git-send-email-andriy.shevchenko@linux.intel.com> <6720400.mTdslW7yXO@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga03.intel.com ([134.134.136.65]:42690 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbbKYMQD (ORCPT ); Wed, 25 Nov 2015 07:16:03 -0500 Content-Disposition: inline In-Reply-To: <6720400.mTdslW7yXO@wuerfel> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Arnd Bergmann Cc: Andy Shevchenko , "Rafael J. Wysocki" , Greg Kroah-Hartman , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Kevin Fenzi , Wolfram Sang On Tue, Nov 24, 2015 at 08:53:04PM +0100, Arnd Bergmann wrote: > On Tuesday 24 November 2015 12:22:57 Andy Shevchenko wrote: > > +static struct property_entry uart_properties[] = { > > + PROPERTY_ENTRY_U32("reg-io-width", 4), > > + PROPERTY_ENTRY_U32("reg-shift", 2), > > + PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1), > > + { }, > > > > If I read the binding correctly, the "snps,uart-16550-compatible" property > is meant to be boolean, meaning true if present and zero-length or false > if absent. Using a u8 propert instead feels wrong. > > Maybe we can have a PROPERTY_ENTRY_BOOL() for that? That's a good idea. We'll add it to the next revision of the series.