linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ACPI / property: fix compile error for acpi_node_get_property_reference() when CONFIG_ACPI=n
@ 2015-12-02  7:44 Hanjun Guo
  2015-12-02  9:10 ` Mika Westerberg
  0 siblings, 1 reply; 2+ messages in thread
From: Hanjun Guo @ 2015-12-02  7:44 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-acpi, Kejian Yan, Hanjun Guo

From: Hanjun Guo <hanjun.guo@linaro.org>

In commit 60ba032ed76e ("ACPI / property: Drop size_prop from
acpi_dev_get_property_reference()"), the argument "const char *cells_name"
was dropped, but forgot to update the stub function in no-ACPI case,
it will lead to compile error when CONFIG_ACPI=n, easliy remove
"const char *cells_name" to fix it.

Reported-by: Kejian Yan <yankejian@huawei.com>
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 include/linux/acpi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 93811dc..7c603e4 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -872,8 +872,8 @@ static inline int acpi_dev_get_property(struct acpi_device *adev,
 }
 
 static inline int acpi_node_get_property_reference(struct fwnode_handle *fwnode,
-				const char *name, const char *cells_name,
-				size_t index, struct acpi_reference_args *args)
+				const char *name, size_t index,
+				struct acpi_reference_args *args)
 {
 	return -ENXIO;
 }
-- 
1.7.12.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI / property: fix compile error for acpi_node_get_property_reference() when CONFIG_ACPI=n
  2015-12-02  7:44 [PATCH] ACPI / property: fix compile error for acpi_node_get_property_reference() when CONFIG_ACPI=n Hanjun Guo
@ 2015-12-02  9:10 ` Mika Westerberg
  0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2015-12-02  9:10 UTC (permalink / raw)
  To: Hanjun Guo; +Cc: Rafael J. Wysocki, linux-acpi, Kejian Yan, Hanjun Guo

On Wed, Dec 02, 2015 at 03:44:22PM +0800, Hanjun Guo wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
> 
> In commit 60ba032ed76e ("ACPI / property: Drop size_prop from
> acpi_dev_get_property_reference()"), the argument "const char *cells_name"
> was dropped, but forgot to update the stub function in no-ACPI case,
> it will lead to compile error when CONFIG_ACPI=n, easliy remove
> "const char *cells_name" to fix it.
> 
> Reported-by: Kejian Yan <yankejian@huawei.com>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-02  9:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-02  7:44 [PATCH] ACPI / property: fix compile error for acpi_node_get_property_reference() when CONFIG_ACPI=n Hanjun Guo
2015-12-02  9:10 ` Mika Westerberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).