From: Darren Hart <dvhart@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Andy Lutomirski" <luto@kernel.org>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Linux ACPI" <linux-acpi@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
"Mario Limonciello" <mario_limonciello@dell.com>,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH v2 3/3] dell-wmi: Improve unknown hotkey handling
Date: Thu, 3 Dec 2015 16:07:21 -0800 [thread overview]
Message-ID: <20151204000721.GF1800@malice.jf.intel.com> (raw)
In-Reply-To: <CALCETrXq3MNAWLWRR47-dW4XhOZCdsMOX=Jz7-frCCb88C8Czg@mail.gmail.com>
On Thu, Dec 03, 2015 at 03:45:11PM -0800, Andy Lutomirski wrote:
> On Thu, Dec 3, 2015 at 3:38 PM, Darren Hart <dvhart@infradead.org> wrote:
> > On Mon, Nov 30, 2015 at 05:02:01PM -0800, Andy Lutomirski wrote:
> >> If DMI lists a hotkey that we don't recognize, log and ignore it
> >> instead of trying to map it to keycode 0. I haven't seen this happen,
> >> but it will help maintain the key map in the future and it will help
> >> avoid sending bogus events.
> >>
> >> This also improves the message that we log when we get an unknown key
> >> event.
> >>
> >> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >> ---
> >
> > Please include the individual patch changelogs here under --- in the patch
> > itself - this helps me build confidence that I am indeed looking at the right
> > patch and the expected changes are here.
>
> Will do in the future -- different maintainers have different
> preferences here, I think.
Oh really?
This is the documented process in Documentation/SubmittingPatches Section 14)
The canonical patch format...
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-12-04 0:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 1:01 [PATCH v2 0/3] dell platform driver tweaks v2 Andy Lutomirski
2015-12-01 1:01 ` [PATCH v2 1/3] dell-wmi: Use a C99-style array for bios_to_linux_keycode Andy Lutomirski
2015-12-03 23:32 ` Darren Hart
2015-12-03 23:45 ` Andy Lutomirski
2015-12-04 0:07 ` Darren Hart
2015-12-01 1:02 ` [PATCH v2 2/3] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake) Andy Lutomirski
2015-12-01 16:38 ` Mario Limonciello
2015-12-03 23:52 ` Darren Hart
2015-12-04 0:00 ` Andy Lutomirski
2015-12-04 9:03 ` Pali Rohár
2015-12-04 16:05 ` Andy Lutomirski
2015-12-01 1:02 ` [PATCH v2 3/3] dell-wmi: Improve unknown hotkey handling Andy Lutomirski
2015-12-03 23:38 ` Darren Hart
2015-12-03 23:45 ` Andy Lutomirski
2015-12-04 0:07 ` Darren Hart [this message]
2015-12-04 0:10 ` Andy Lutomirski
2015-12-04 0:21 ` Darren Hart
2015-12-04 8:39 ` Pali Rohár
2015-12-04 16:15 ` Andy Lutomirski
2015-12-09 0:33 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204000721.GF1800@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox