Re: [PATCH v2 2/3] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake)

Pali Rohár
2015-12-04T09:03:49Z

On Monday 30 November 2015 17:02:00 Andy Lutomirski wrote:
> + /*
> + * Check if we've already found this scancode. This takes
> + * quadratic time, but it doesn't matter unless the list
> + * of extra keys gets very long.
> + */
> + for (j = 0; j < num_bios_keys; j++)
> + if (keymap[j].code == dell_wmi_extra_keymap[i].code)
> + goto skip;
> +

Still, my comment about moving this loop into function is valid...

> + keymap[pos] = dell_wmi_extra_keymap[i];
> + pos++;
> +
> +skip:
> + ;
> }

--
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html