Re: [PATCH v2 3/3] dell-wmi: Improve unknown hotkey handling

Pali Rohár
2015-12-04T08:39:23Z

On Thursday 03 December 2015 15:38:56 Darren Hart wrote:
> Pali, this appears to have the one change you asked for (0x%x instead of %d).
> I've added the Reviewed-by: Pali Rohár <pali.rohar@gmail.com> you provided
> previously pending this change.

Ok.

> > + /* Uninitialized entries are 0 aka KEY_RESERVED. */
> > + u16 keycode = (bios_entry->keycode <
> > + ARRAY_SIZE(bios_to_linux_keycode)) ?
> > + bios_to_linux_keycode[bios_entry->keycode] :
> > + KEY_RESERVED;
> > + BUILD_BUG_ON(KEY_RESERVED != 0);

Anyway, Darren what do you think is that BUILD_BUG_ON check needed?

--
Pali Rohár
pali.rohar@gmail.com