From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Christophe Ricard <christophe.ricard@gmail.com>
Cc: rjw@rjwysocki.net, lenb@kernel.org, linus.walleij@linaro.org,
gnurou@gmail.com, andriy.shevchenko@linux.intel.com,
broonie@kernel.org, linux-spi@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
Christophe Ricard <christophe-h.ricard@st.com>
Subject: Re: [PATCH v4 1/3] acpi: Rename acpi_gsi_get_irq_type to acpi_get_irq_type and export symbol
Date: Wed, 9 Dec 2015 15:36:46 +0200 [thread overview]
Message-ID: <20151209133646.GV1766@lahna.fi.intel.com> (raw)
In-Reply-To: <5667523F.60704@gmail.com>
On Tue, Dec 08, 2015 at 10:57:19PM +0100, Christophe Ricard wrote:
> I believe changes done in this patch take benefit of another existing
> function used in acpi gsi context that is doing the
> job as expected.
>
> Do you still believe acpi_dev_irq_flags is more appropriate ?
I don't have strong feelings about that. I just wanted to point out
there already exists such function.
However, if you do use acpi_gsi_get_irq_type() I think it should be
placed to the same file as acpi_dev_irq_flags().
next prev parent reply other threads:[~2015-12-09 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 22:39 [PATCH v4 0/3] ACPI: Add irq_type to gpio interrupt Christophe Ricard
2015-12-07 22:39 ` [PATCH v4 1/3] acpi: Rename acpi_gsi_get_irq_type to acpi_get_irq_type and export symbol Christophe Ricard
2015-12-08 11:28 ` Mika Westerberg
[not found] ` <20151208112855.GI1766-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-12-08 21:57 ` Christophe Ricard
2015-12-09 13:36 ` Mika Westerberg [this message]
2015-12-09 14:19 ` Andy Shevchenko
[not found] ` <1449527952-8399-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2015-12-07 22:39 ` [PATCH v4 2/3] ACPI / gpio: Add irq_type when a gpio is used as an interrupt Christophe Ricard
2015-12-08 11:33 ` Mika Westerberg
2015-12-07 22:39 ` [PATCH v4 3/3] ACPI / spi: attach gpio irq from acpi description to spi device Christophe Ricard
2015-12-08 11:35 ` Mika Westerberg
2015-12-08 11:59 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209133646.GV1766@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=christophe-h.ricard@st.com \
--cc=christophe.ricard@gmail.com \
--cc=gnurou@gmail.com \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox