* [PATCH] acpi: avoid leaking format string into kobject name
@ 2016-01-07 19:24 Kees Cook
2016-01-08 0:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2016-01-07 19:24 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, linux-acpi, linux-kernel
The dn->name is expected to be used as a literal, so add the missing
"%s".
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/acpi/device_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 707cf6213bc2..b9afb47db7ed 100644
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -104,7 +104,7 @@ static void acpi_expose_nondev_subnodes(struct kobject *kobj,
init_completion(&dn->kobj_done);
ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype,
- kobj, dn->name);
+ kobj, "%s", dn->name);
if (ret)
acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret);
else
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] acpi: avoid leaking format string into kobject name
2016-01-07 19:24 [PATCH] acpi: avoid leaking format string into kobject name Kees Cook
@ 2016-01-08 0:44 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-01-08 0:44 UTC (permalink / raw)
To: Kees Cook; +Cc: Len Brown, linux-acpi, linux-kernel
On Thursday, January 07, 2016 11:24:29 AM Kees Cook wrote:
> The dn->name is expected to be used as a literal, so add the missing
> "%s".
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied, thanks!
> ---
> drivers/acpi/device_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index 707cf6213bc2..b9afb47db7ed 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -104,7 +104,7 @@ static void acpi_expose_nondev_subnodes(struct kobject *kobj,
>
> init_completion(&dn->kobj_done);
> ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype,
> - kobj, dn->name);
> + kobj, "%s", dn->name);
> if (ret)
> acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret);
> else
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-08 0:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-07 19:24 [PATCH] acpi: avoid leaking format string into kobject name Kees Cook
2016-01-08 0:44 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox