Re: [PATCH v4] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake)

[Darren Hart <dvhart@infradead.org>]

On Wed, Jan 20, 2016 at 12:46:23PM -0800, Andy Lutomirski wrote:
> On Wed, Jan 20, 2016 at 11:40 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > On Tuesday 19 January 2016 15:07:47 Andy Lutomirski wrote:
> >> The XPS 13 9350 sends WMI keypress events that aren't enumerated in
> >> the DMI table.  Add a table listing them.  To avoid breaking things
> >> that worked before, these un-enumerated hotkeys won't be used if the
> >> DMI table maps them to something else.
> >>
> >> FWIW, it appears that the DMI table may be a legacy thing and we
> >> might want to rethink how we handle events in general.  As an
> >> example, a whole lot of things map to KEY_PROG3 via the DMI table.
> >>
> >> So far, this doesn't send keypress events for any of the new
> >> events.  Depnding on whether we figure out exactly what needs to
> >> happen to get the wireless button working in time for Linux 4.5,
> >> we might want to temporarily handle it in dell-wmi.
> >>
> >> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >
> > Looks good,
> >
> > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> 
> Darren, if/when you apply this, can you fix up the last paragraph of
> the commit message?
> 
>     This doesn't send keypress events for any of the new
>     events, as no models appear to require it.
> 
> I wrote the old text before intel-hid landed.

Planning on queueing for 4.6 as soon as this window closes, likely tomorrow. I
want this to have some time in -next. Thanks!

> 
> --Andy
> 

-- 
Darren Hart
Intel Open Source Technology Center