From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH v3 04/12] acpi, numa: introduce ACPI_HAS_NUMA_ARCH_FIXUP Date: Sat, 23 Jan 2016 11:25:23 +0100 Message-ID: <20160123102523.GC24726@rric.localdomain> References: <1453541967-3744-1-git-send-email-guohanjun@huawei.com> <1453541967-3744-5-git-send-email-guohanjun@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1453541967-3744-5-git-send-email-guohanjun@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Hanjun Guo Cc: "Rafael J. Wysocki" , Will Deacon , Catalin Marinas , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ganapatrao Kulkarni , Lorenzo Pieralisi , Shannon Zhao , Steve Capper , Mark Rutland , Hanjun Guo List-Id: linux-acpi@vger.kernel.org On 23.01.16 17:39:19, Hanjun Guo wrote: > From: Hanjun Guo > > acpi_numa_arch_fixup() is only used for IA64, x86 introduce a dummy > function for it, when we came to a new architecture (such as ARM64), > we need to introduce another dummy one to make the code compile. > > That's pretty boring so introduce ACPI_HAS_NUMA_ARCH_FIXUP and > select it for IA64, introduce a stub function for acpi_numa_arch_fixup() > then it's pretty clean for x86 and ARM64. > > Signed-off-by: Hanjun Guo > --- > arch/ia64/Kconfig | 1 + I see an implementation of acpi_numa_arch_fixup() only for ia64. Why not move it to arch/ia64 then and call it from setup_arch() in arch/ia64/kernel/setup.c after acpi_numa_init()? It looks like we don't need a generic solution for this. This avoids any kconfig handling for this at all. -Robert