From: Guenter Roeck <linux@roeck-us.net>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
rjw@rjwysocki.net, lenb@kernel.org, izumi.taku@jp.fujitsu.com,
wency@cn.fujitsu.com, caoj.fnst@cn.fujitsu.com,
ddaney.cavm@gmail.com, okaya@codeaurora.org, bhelgaas@google.com,
jiang.liu@linux.int
Subject: Re: [PATCH v2] pci: fix unavailable irq number 255 reported by BIOS
Date: Mon, 25 Jan 2016 20:05:25 -0800 [thread overview]
Message-ID: <20160126040525.GA15074@roeck-us.net> (raw)
In-Reply-To: <20160125205803.GA10272@localhost>
On Mon, Jan 25, 2016 at 02:58:04PM -0600, Bjorn Helgaas wrote:
> [+cc Thomas]
>
[ ... ]
>
> I don't like the x86 ifdef. I'd prefer:
>
> static inline bool irq_valid(unsigned int irq)
> {
> if (irq < NR_IRQS)
> return true;
> return false;
> }
>
Or:
static inline bool irq_valid(unsigned int irq)
{
return irq < NR_IRQS;
}
Guenter
next prev parent reply other threads:[~2016-01-26 4:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 6:59 [PATCH v2] pci: fix unavailable irq number 255 reported by BIOS Chen Fan
2016-01-25 20:58 ` Bjorn Helgaas
2016-01-26 1:40 ` Chen Fan
2016-01-26 4:05 ` Guenter Roeck [this message]
2016-01-26 8:26 ` Thomas Gleixner
2016-01-26 9:45 ` Chen Fan
2016-01-26 9:51 ` Thomas Gleixner
2016-01-26 15:22 ` Bjorn Helgaas
2016-01-26 15:48 ` Thomas Gleixner
2016-01-27 0:25 ` Bjorn Helgaas
2016-01-27 5:24 ` Cao jin
2016-01-27 8:35 ` Thomas Gleixner
2016-01-27 9:13 ` Thomas Gleixner
2016-01-27 22:32 ` Bjorn Helgaas
2016-01-28 1:00 ` Chen Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126040525.GA15074@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bhelgaas@google.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=ddaney.cavm@gmail.com \
--cc=helgaas@kernel.org \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@linux.int \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox