From: Mark Rutland <mark.rutland@arm.com>
To: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Cc: "Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>,
"Wangzhou (B)" <wangzhou1@hisilicon.com>,
"liudongdong (C)" <liudongdong3@huawei.com>,
Linuxarm <linuxarm@huawei.com>, qiujiang <qiujiang@huawei.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"Lorenzo.Pieralisi@arm.com" <Lorenzo.Pieralisi@arm.com>,
"tn@semihalf.com" <tn@semihalf.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xuwei (O)" <xuwei5@hisilicon.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"jcm@redhat.com" <jcm@redhat.com>,
zhangjukuo <zhangjukuo@huawei.com>,
"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v3 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers
Date: Wed, 10 Feb 2016 11:12:34 +0000 [thread overview]
Message-ID: <20160210111234.GC2632@leverpostej> (raw)
In-Reply-To: <EE11001F9E5DDD47B7634E2F8A612F2E1ECB1591@lhreml503-mbs>
On Wed, Feb 10, 2016 at 09:52:36AM +0000, Gabriele Paoloni wrote:
> Hi Mark
>
> > On Tue, Feb 09, 2016 at 05:34:20PM +0000, Gabriele Paoloni wrote:
> > > From: gabriele paoloni <gabriele.paoloni@huawei.com>
> > > +/*
> > > + * Retrieve rc_dbi base and size from _DSD
> > > + * Name (_DSD, Package () {
> > > + * ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > + * Package () {
> > > + * Package () {"rc-dbi", Package () { 0x0, 0xb0080000, 0x0, 0x10000
> > }},
> > > + * }
> > > + * })
> > > + */
> >
> > As above, this does not look right. ACPI has standard mechanisms for
> > describing addresses. Making something up like this is not a good idea.
>
> I am quite new to ACPI, may I ask you to explain a bit?
ACPI has standard mechanisms for describing certain resources, and these
should not be described in _DSD. Memory or IO address regions are such
resources (in _CRS, IIRC), and should not be described in _DSD.
Thanks,
Mark.
next prev parent reply other threads:[~2016-02-10 11:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 17:34 [RFC PATCH v3 0/3] Add ACPI support for HiSilicon PCIe Host Controllers Gabriele Paoloni
2016-02-09 17:34 ` [RFC PATCH v3 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI Gabriele Paoloni
2016-02-09 17:34 ` [RFC PATCH v3 2/3] PCI: hisi: Add ECAM support to HiSilicon PCIe host controller Gabriele Paoloni
2016-02-09 18:16 ` Mark Rutland
2016-02-10 9:39 ` Gabriele Paoloni
2016-02-09 17:34 ` [RFC PATCH v3 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Gabriele Paoloni
2016-02-09 18:24 ` Mark Rutland
2016-02-10 9:52 ` Gabriele Paoloni
2016-02-10 11:12 ` Mark Rutland [this message]
2016-02-10 14:45 ` Gabriele Paoloni
2016-02-23 2:47 ` Gabriele Paoloni
2016-02-24 1:14 ` Bjorn Helgaas
2016-02-24 6:46 ` Gabriele Paoloni
2016-02-24 15:25 ` Bjorn Helgaas
2016-02-25 3:01 ` Gabriele Paoloni
2016-02-25 12:07 ` Lorenzo Pieralisi
2016-02-25 19:59 ` Bjorn Helgaas
2016-02-25 21:24 ` Rafael J. Wysocki
2016-03-02 14:32 ` Bjorn Helgaas
2016-02-27 9:00 ` Gabriele Paoloni
2016-02-29 11:38 ` Lorenzo Pieralisi
2016-03-03 14:21 ` Gabriele Paoloni
2016-03-01 19:22 ` Lorenzo Pieralisi
2016-03-02 15:51 ` Bjorn Helgaas
2016-03-09 7:41 ` Gabriele Paoloni
2016-03-14 19:16 ` Bjorn Helgaas
2016-03-15 11:13 ` Gabriele Paoloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210111234.GC2632@leverpostej \
--to=mark.rutland@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=guohanjun@huawei.com \
--cc=jcm@redhat.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=qiujiang@huawei.com \
--cc=tn@semihalf.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangjukuo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).