From: Thierry Reding <treding@nvidia.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lee Jones <lee.jones@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] device property: don't bother the drivers with struct property_set
Date: Fri, 26 Feb 2016 16:35:31 +0100 [thread overview]
Message-ID: <20160226153530.GC9111@ulmo.nvidia.com> (raw)
In-Reply-To: <1456485600-129229-1-git-send-email-heikki.krogerus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On Fri, Feb 26, 2016 at 01:20:00PM +0200, Heikki Krogerus wrote:
> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
>
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> arch/arm/mach-tegra/board-paz00.c | 6 +-----
> drivers/base/platform.c | 19 ++++++++++---------
> drivers/base/property.c | 35 ++++++++++++++++++++++-------------
> drivers/mfd/intel-lpss-acpi.c | 6 +-----
> drivers/mfd/intel-lpss-pci.c | 14 +++-----------
> drivers/mfd/intel-lpss.c | 2 +-
> drivers/mfd/intel-lpss.h | 2 +-
> drivers/mfd/mfd-core.c | 4 ++--
> include/linux/mfd/core.h | 2 +-
> include/linux/platform_device.h | 4 ++--
> include/linux/property.h | 15 +++------------
> 11 files changed, 47 insertions(+), 62 deletions(-)
For the Tegra bits:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-26 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 11:20 [PATCH] device property: don't bother the drivers with struct property_set Heikki Krogerus
2016-02-26 14:35 ` Andy Shevchenko
2016-02-26 15:35 ` Thierry Reding [this message]
2016-02-29 12:59 ` Mika Westerberg
2016-03-02 13:03 ` Lee Jones
2016-03-15 9:04 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226153530.GC9111@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).