From: "Zhang, Haozhong" <haozhong.zhang@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH v2] nfit: Continue init even if ARS commands are unimplemented
Date: Fri, 4 Mar 2016 11:34:51 +0800 [thread overview]
Message-ID: <20160304033451.GA6267@hz-desktop.sh.intel.com> (raw)
In-Reply-To: <56D900EA.2060802@linux.intel.com>
On 03/04/16 11:28, Xiao Guangrong wrote:
>
> CCed: Haozhong.
>
> On 03/04/2016 06:39 AM, Vishal Verma wrote:
> >If firmware doesn't implement any of the ARS commands, take that to
> >mean that ARS is unsupported, and continue to initialize regions without
> >bad block lists. We cannot make the assumption that ARS commands will be
> >unconditionally supported on all NVDIMMs.
> >
> >Cc: Dan Williams <dan.j.williams@intel.com>
> >Reported-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>
> Thank you for the fix, Vishal! it looks good to me.
>
> However, It is haozhong's credit as he is the one reported the bug not
> me. :)
>
Thanks! I have tested on QEMU which has not implemented ARS yet and
this patch does work.
Tested-by: Haozhong Zhang <haozhong.zhang@intel.com>
next prev parent reply other threads:[~2016-03-04 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 22:39 [PATCH v2] nfit: Continue init even if ARS commands are unimplemented Vishal Verma
2016-03-03 22:53 ` Dan Williams
2016-03-04 3:28 ` Xiao Guangrong
2016-03-04 3:34 ` Zhang, Haozhong [this message]
2016-03-04 4:27 ` Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304033451.GA6267@hz-desktop.sh.intel.com \
--to=haozhong.zhang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).