From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juri Lelli Subject: Re: [PATCH v5 6/7][Update] cpufreq: Support for fast frequency switching Date: Thu, 17 Mar 2016 11:48:22 +0000 Message-ID: <20160317114822.GI18212@e106622-lin> References: <2495375.dFbdlAZmA6@vostro.rjw.lan> <4088601.C2vItRYpQn@vostro.rjw.lan> <1711281.bPmSjlBT7c@vostro.rjw.lan> <4785370.no59v8qjgi@vostro.rjw.lan> <20160317113507.GH18212@e106622-lin> <20160317114037.GB6356@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160317114037.GB6356@twins.programming.kicks-ass.net> Sender: linux-pm-owner@vger.kernel.org To: Peter Zijlstra Cc: "Rafael J. Wysocki" , Linux PM list , Steve Muckle , ACPI Devel Maling List , Linux Kernel Mailing List , Srinivas Pandruvada , Viresh Kumar , Vincent Guittot , Michael Turquette , Ingo Molnar List-Id: linux-acpi@vger.kernel.org On 17/03/16 12:40, Peter Zijlstra wrote: > On Thu, Mar 17, 2016 at 11:35:07AM +0000, Juri Lelli wrote: > > > > + pr_warn("cpufreq: CPU%u: Fast freqnency switching not enabled\n", > > > > Ultra-minor nit: s/freqnency/frequency/ > > > > Also, is this really a warning or just a debug message? (everything > > seems to work fine on Juno even if this is printed :-)). > > I would consider it a warn; this _should_ not happen. If your platform > supports fast_switch, then you really rather want to use it. > Mmm, right. So, something seems not correct here, as I get this warning when I select schedutil on Juno (that doesn't support fast_switch).