From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3] device property: don't bother the drivers with struct property_set Date: Tue, 12 Apr 2016 08:24:01 +0100 Message-ID: <20160412072401.GF8094@x1> References: <1459252343-105426-1-git-send-email-heikki.krogerus@linux.intel.com> <20160411082027.GF4592@x1> <20160411095234.GA26606@kuha.fi.intel.com> <20160411140541.GY8094@x1> <20160411162034.GA8094@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Heikki Krogerus , Daniel Mack , "Rafael J. Wysocki" , Mika Westerberg , Andy Shevchenko , Thierry Reding , ACPI Devel Maling List , Linux Kernel Mailing List List-Id: linux-acpi@vger.kernel.org On Mon, 11 Apr 2016, Rafael J. Wysocki wrote: > On Mon, Apr 11, 2016 at 6:20 PM, Lee Jones wro= te: > > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote: > > > >> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones = wrote: > >> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote: > >> > > >> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus > >> >> wrote: > >> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote: > >> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote: > >> >> >> > >> >> >> > Since device_add_property_set() now always takes a copy of > >> >> >> > the property_set, and also since the fwnode type is always > >> >> >> > hard coded to be FWNODE_PDATA, there is no need for the > >> >> >> > drivers to deliver the entire struct property_set. The > >> >> >> > function can just create the instance of it on its own and > >> >> >> > bind the properties from the drivers to it on the spot. > >> >> >> > > >> >> >> > This renames device_add_property_set() to > >> >> >> > device_add_properties(). The function now takes struct > >> >> >> > property_entry as its parameter instead of struct > >> >> >> > property_set. > >> >> >> > > >> >> >> > Reviewed-by: Andy Shevchenko > >> >> >> > Reviewed-by: Mika Westerberg > >> >> >> > Acked-by: Thierry Reding > >> >> >> > Acked-by: Lee Jones > >> >> >> > Signed-off-by: Heikki Krogerus > >> >> >> > --- > >> >> >> > arch/arm/mach-pxa/raumfeld.c | 12 ++++-------- > >> >> > > >> >> > Daniel, I think we just need your ACK for this one. > >> >> > > >> >> > Otherwise I think we are covered. > >> >> > > >> >> >> > arch/arm/mach-tegra/board-paz00.c | 6 +----- > >> >> >> > drivers/base/platform.c | 19 ++++++++++--------= - > >> >> >> > drivers/base/property.c | 34 ++++++++++++++++++= +++------------- > >> >> >> > drivers/mfd/intel-lpss-acpi.c | 12 ++---------- > >> >> >> > drivers/mfd/intel-lpss-pci.c | 20 ++++--------------= -- > >> >> >> > drivers/mfd/intel-lpss.c | 2 +- > >> >> >> > drivers/mfd/intel-lpss.h | 4 ++-- > >> >> >> > drivers/mfd/mfd-core.c | 4 ++-- > >> >> >> > include/linux/mfd/core.h | 4 ++-- > >> >> >> > include/linux/platform_device.h | 6 +++--- > >> >> >> > include/linux/property.h | 15 +++------------ > >> >> >> > 12 files changed, 55 insertions(+), 83 deletions(-) > >> >> >> > >> >> >> What's happening with this patch? I believe we're still mis= sing > >> >> >> Acks. Once they are collected someone needs to create an im= mutable > >> >> >> branch and send out a pull-request. > >> >> > > >> >> > Rafael, have you had time to take a look at this? > >> >> > >> >> Yes, it's in my bleeding-edge branch now. I'm planning to move= it to > >> >> linux-next this week > >> > > >> > Please ensure you send out the relevant pull-requests. Linus do= esn't > >> > look his best when he's angry. > >> > >> I guess you mean I should expose by device-properties branch and > >> notify the relevant people about that, right? > > > > Exactly. And the easiest way to do that is by sending out a > > pull-request. >=20 > I hoping that sending a message with the relevant information in a > reply to this one will be sufficient. Because of the nature of MFD, I end up doing this kind of thing a lot. Here's what I normally do. Normally in reply to the cover-letter (0/x)= : https://lkml.org/lkml/2015/8/12/138 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog