From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Tony Makkiel <tony.makkiel@daqri.com>
Cc: linux-leds@vger.kernel.org, linux-acpi@vger.kernel.org,
j.anaszewski@samsung.com, rpurdie@rpsys.net, rjw@rjwysocki.net,
lenb@kernel.org
Subject: Re: [PATCH v8 1/1] leds: LED driver for TI LP3952 6-Channel Color LED
Date: Wed, 6 Jul 2016 11:23:40 +0300 [thread overview]
Message-ID: <20160706082340.GV23527@lahna.fi.intel.com> (raw)
In-Reply-To: <1467732628-2025-1-git-send-email-tony.makkiel@daqri.com>
On Tue, Jul 05, 2016 at 04:30:28PM +0100, Tony Makkiel wrote:
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id lp3952_acpi_match[] = {
> + {LP3952_ACPI_NAME, 0},
I would just drop the silly macro and use
{ "TXNW3952" },
instead.
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
> +#endif
> +
> +static struct i2c_driver lp3952_i2c_driver = {
> + .driver = {
> + .name = LP3952_NAME,
> + .acpi_match_table = ACPI_PTR(lp3952_acpi_match),
> + },
> + .probe = lp3952_probe,
> + .remove = lp3952_remove,
> + .id_table = lp3952_id,
> +};
> +
Anyway ACPI parts look good enough,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2016-07-06 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 15:30 [PATCH v8 1/1] leds: LED driver for TI LP3952 6-Channel Color LED Tony Makkiel
2016-07-06 8:23 ` Mika Westerberg [this message]
2016-07-06 13:33 ` Jacek Anaszewski
2016-07-06 15:05 ` Tony
2016-07-07 7:13 ` Jacek Anaszewski
2016-07-07 11:44 ` Tony
2016-07-07 14:34 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706082340.GV23527@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=j.anaszewski@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rpurdie@rpsys.net \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).