From: Wolfram Sang <wsa@the-dreams.de>
To: Lv Zheng <lv.zheng@intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Lv Zheng <zetalog@gmail.com>,
linux-acpi@vger.kernel.org, Nicholas <nkudriavtsev@gmail.com>
Subject: Re: [UPDATE RFC PATCH v2] ACPI / EC: Fix an order issue in ec_remove_handlers()
Date: Thu, 7 Jul 2016 20:46:55 +0900 [thread overview]
Message-ID: <20160707114654.GA2915@tetsubishi> (raw)
In-Reply-To: <e48b77b7af1e8269b0ff3fac6cbf37eb480ab722.1467866123.git.lv.zheng@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]
On Thu, Jul 07, 2016 at 12:37:10PM +0800, Lv Zheng wrote:
> (Updated to add v2 indicator)
>
> There is an order issue in ec_remove_handlers() that the functions invoked
> in it are not invoked in the reversed order of their appearance in
> ec_install_handlers(). This existing issue has been triggered by the
> following commit:
> Commit: dcf15cbded656a12335bc4151f3f75f10080a375
> Subject: ACPI / EC: Fix a boot EC regresion by restoring boot EC
> The commit invokes ec_remove_handlers() during runtime, thus uncovers this
> issue. This patch fixes this regression.
>
> Fixes: dcf15cbded65 ("ACPI / EC: Fix a boot EC regresion by restoring boot EC")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=102421
> Reported-by: Wolfram Sang <wsa@the-dreams.de>
> Reported-by: Nicholas <nkudriavtsev@gmail.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: Nicholas <nkudriavtsev@gmail.com>
> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Tested-by: Wolfram Sang <wsa@the-dreams.de>
The status infos are back to normal and the EC error reports are gone
from the log. Looks good! Thanks for the quick fix.
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-07 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 14:14 Regression between rc2 and rc6: ACPI EC problems Wolfram Sang
2016-07-06 21:28 ` Rafael J. Wysocki
2016-07-07 0:26 ` Zheng, Lv
2016-07-07 0:36 ` Rafael J. Wysocki
2016-07-07 0:34 ` Zheng, Lv
2016-07-07 0:30 ` Zheng, Lv
2016-07-07 0:31 ` Zheng, Lv
2016-07-07 1:49 ` [RFC PATCH] ACPI / EC: Fix an order issue in ec_remove_handlers() Lv Zheng
2016-07-07 4:38 ` Zheng, Lv
2016-07-07 4:37 ` [UPDATE RFC PATCH v2] " Lv Zheng
2016-07-07 11:46 ` Wolfram Sang [this message]
2016-07-08 0:38 ` Zheng, Lv
2016-07-08 1:25 ` [PATCH v3] " Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707114654.GA2915@tetsubishi \
--to=wsa@the-dreams.de \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=nkudriavtsev@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).