From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v9 1/1] leds: LED driver for TI LP3952 6-Channel Color LED Date: Sat, 9 Jul 2016 11:08:32 +0300 Message-ID: <20160709080832.GA14693@lahna.fi.intel.com> References: <1467974244-3161-1-git-send-email-tony.makkiel@daqri.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Tony Makkiel , linux-leds@vger.kernel.org, ACPI Devel Maling List , Jacek Anaszewski , rpurdie@rpsys.net, "Rafael J. Wysocki" , Len Brown List-Id: linux-acpi@vger.kernel.org On Fri, Jul 08, 2016 at 09:28:06PM +0200, Rafael J. Wysocki wrote: > On Fri, Jul 8, 2016 at 12:37 PM, Tony Makkiel wrote: > > The chip can drive 2 sets of RGB leds. Controller can > > be controlled via PWM, I2C and audio synchronisation. > > This driver uses I2C to communicate with the chip. > > > > Datasheet: http://www.ti.com/lit/gpn/lp3952 > > > > Signed-off-by: Tony Makkiel > > >From the ACPI perspective, I don't see anything objectionable here. > > Mika, do you agree? Yes, looks fine to me.