From mboxrd@z Thu Jan 1 00:00:00 1970 From: joeyli Subject: Re: [PATCH v2] tools/testing/nvdimm: add virtual ramdisk range Date: Tue, 19 Jul 2016 14:53:51 +0800 Message-ID: <20160719065351.GA30398@linux-rxt1.site> References: <146861130048.16896.9105590813517990661.stgit@dwillia2-desk3.amr.corp.intel.com> <20160717093614.GM27155@linux-rxt1.site> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.nue.novell.com ([195.135.221.5]:57471 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269AbcGSGyN (ORCPT ); Tue, 19 Jul 2016 02:54:13 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dan Williams Cc: Linux ACPI , "linux-nvdimm@lists.01.org" On Sun, Jul 17, 2016 at 09:05:19AM -0700, Dan Williams wrote: > On Sun, Jul 17, 2016 at 2:36 AM, joeyli wrote: > > Hi Dan, > > > > On Fri, Jul 15, 2016 at 12:35:58PM -0700, Dan Williams wrote: > >> Test the virtual disk ranges that platform firmware like EDK2/OVMF might > >> emit. > >> > >> Cc: "Lee, Chun-Yi" > >> Signed-off-by: Dan Williams > >> --- > >> Changes since v1: > >> > >> * Move this test range to nfit_test.1 to not break the spa ordering > >> expected by the nfit_test.0 tests. > >> > > > > I reviewed and tested this patch by nvdimm testing driver. > > Please feel free to add > > Reviewed-by: Lee, Chun-Yi > > > > But I have a question to run nfit testing driver on OVMF. I always got > > "coherent allocation failed" as below: > > > > [ 86.530950] platform nfit_test.0: swiotlb buffer is full (sz: 134217728 bytes) > > [ 86.530954] swiotlb: coherent allocation failed for device nfit_test.0 size=134217728 > > [ 86.530956] CPU: 0 PID: 1291 Comm: insmod Tainted: G OE 4.7.0-rc7-default+ #323 > > [ 86.530958] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 > > [ 86.530959] 0000000000000000 ffff880234e63bb0 ffffffff81334e5c 0000000008000000 > > [ 86.530961] ffff880232fa5998 ffff880234e63bf0 ffffffff8135eb79 ffff88020000000f > > [ 86.530963] 00000000024002c0 ffff880232fa5998 0000000008000000 ffff880234e63c68 > > [ 86.530965] Call Trace: > > [ 86.530971] [] dump_stack+0x63/0x87 > > [ 86.530975] [] swiotlb_alloc_coherent+0x149/0x160 > > [ 86.530978] [] x86_swiotlb_alloc_coherent+0x43/0x50 > > [ 86.530981] [] dma_alloc_attrs.constprop.10+0x5a/0x80 [nfit_test] > > [ 86.530984] [] nfit_test_init+0x18c/0x1000 [nfit_test] > > [ 86.530985] [] ? 0xffffffffa00d6000 > > [ 86.530988] [] do_one_initcall+0x50/0x190 > > [ 86.530992] [] ? kmem_cache_alloc_trace+0x170/0x220 > > [ 86.530995] [] ? do_init_module+0x27/0x1e2 > > [ 86.530997] [] do_init_module+0x60/0x1e2 > > [ 86.531000] [] load_module+0x1411/0x1c20 > > [ 86.531002] [] ? __symbol_put+0x40/0x40 > > [ 86.531006] [] ? ima_post_read_file+0x3d/0x80 > > [ 86.531009] [] SYSC_finit_module+0xa9/0xd0 > > [ 86.531011] [] SyS_finit_module+0xe/0x10 > > [ 86.531013] [] do_syscall_64+0x62/0x110 > > [ 86.531016] [] entry_SYSCALL64_slow_path+0x25/0x25 > > [ 86.531018] platform nfit_test.0: need 128M of free cma > > > > I tried to add "swiotlb=65536" and "cma=128M" or "cma=256M", even "cma=2G" kernel > > parameters, but nfit-test.ko still can NOT allocate DMA success. > > > > So, I always add a patch to change the DIMM_SIZE to SZ_1M, that means test0 > > only uses 4M. Then the nfit-test.ko works for testing. > > > > Did I miss anything before running the nfit testing driver? > > The CMA dependency is a hassle, so for v4.8 I'm replacing it with vmalloc: > > https://patchwork.kernel.org/patch/9199761/ > https://patchwork.kernel.org/patch/9199763/ Those patches work great! Thanks a lot! Joey Lee