public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexey Klimov <alexey.klimov@arm.com>
To: Prashanth Prakash <pprakash@codeaurora.org>
Cc: linux-acpi@vger.kernel.org, rjw@rjwysocki.net, hotran@apm.com,
	cov@codeaurora.org
Subject: Re: [PATCH V2 4/5] ACPI/CPPC: set a non-zero value for transition_latency
Date: Mon, 8 Aug 2016 12:01:53 +0100	[thread overview]
Message-ID: <20160808110153.GA27382@arm.com> (raw)
In-Reply-To: <1469562328-10201-5-git-send-email-pprakash@codeaurora.org>

On Tue, Jul 26, 2016 at 01:45:27PM -0600, Prashanth Prakash wrote:
> Compute the expected transition latency for frequency transitions
> using the values from the PCCT tables when the desired perf
> register is in PCC.
> 
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Signed-off-by: Prashanth Prakash <pprakash@codeaurora.org>


Reviewed-by: Alexey Klimov <alexey.klimov@arm.com>


> ---
>  drivers/acpi/cppc_acpi.c       | 46 ++++++++++++++++++++++++++++++++++++++++--
>  drivers/cpufreq/cppc_cpufreq.c |  1 +
>  include/acpi/cppc_acpi.h       |  1 +
>  3 files changed, 46 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 4a887d4..93abaec 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -85,7 +85,7 @@ static void __iomem *pcc_comm_addr;
>  static int pcc_subspace_idx = -1;
>  static bool pcc_channel_acquired;
>  static ktime_t deadline;
> -static unsigned int pcc_mpar, pcc_mrtt;
> +static unsigned int pcc_mpar, pcc_mrtt, pcc_nominal;
>  
>  /* pcc mapped address + header size + offset within PCC subspace */
>  #define GET_PCC_VADDR(offs) (pcc_comm_addr + 0x8 + (offs))
> @@ -462,7 +462,6 @@ static int register_pcc_channel(int pcc_subspace_idx)
>  			return -ENODEV;
>  		}
>  
> -
>  		/*
>  		 * cppc_ss->latency is just a Nominal value. In reality
>  		 * the remote processor could be much slower to reply.
> @@ -472,6 +471,7 @@ static int register_pcc_channel(int pcc_subspace_idx)


  reply	other threads:[~2016-08-08 11:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 19:45 [PATCH V2 0/5] CPPC enhancements Prashanth Prakash
2016-07-26 19:45 ` [PATCH V2 1/5] ACPI/CPPC: restructure read/writes for efficient sys mapped reg ops Prashanth Prakash
2016-07-26 19:45 ` [PATCH V2 2/5] ACPI/CPPC: acquire pcc_lock only while accessing PCC subspace Prashanth Prakash
2016-07-26 19:45 ` [PATCH V2 3/5] ACPI/CPPC: support for batching CPPC requests Prashanth Prakash
2016-08-09  0:09   ` Prakash, Prashanth
2016-08-12 12:40     ` Alexey Klimov
2016-08-12 16:27       ` Prakash, Prashanth
2016-08-12 16:32         ` Prakash, Prashanth
2016-08-12 17:42         ` Alexey Klimov
2016-08-12 21:30           ` Prakash, Prashanth
2016-08-15 13:46             ` Alexey Klimov
2016-07-26 19:45 ` [PATCH V2 4/5] ACPI/CPPC: set a non-zero value for transition_latency Prashanth Prakash
2016-08-08 11:01   ` Alexey Klimov [this message]
2016-07-26 19:45 ` [PATCH V2 5/5] ACPI/CPPC: add sysfs support to compute delivered performance Prashanth Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160808110153.GA27382@arm.com \
    --to=alexey.klimov@arm.com \
    --cc=cov@codeaurora.org \
    --cc=hotran@apm.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=pprakash@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox