From: Lukas Wunner <lukas@wunner.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-efi@vger.kernel.org,
Matt Fleming <matt@codeblueprint.co.uk>,
linux-kernel@vger.kernel.org,
Andreas Noever <andreas.noever@gmail.com>,
Pierre Moreau <pierre.morrow@free.fr>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/6] driver core: Don't leak secondary fwnode on device removal
Date: Tue, 30 Aug 2016 11:03:25 +0200 [thread overview]
Message-ID: <20160830090325.GA25024@wunner.de> (raw)
In-Reply-To: <6868582.iUcUV1Tb36@vostro.rjw.lan>
On Wed, Aug 17, 2016 at 02:38:50AM +0200, Rafael J. Wysocki wrote:
> On Thursday, July 28, 2016 02:25:41 AM Lukas Wunner wrote:
> > If device_add_property_set() is called for a device, a secondary fwnode
> > is allocated and assigned to the device but currently not freed once the
> > device is removed.
> >
> > This can be triggered on Apple Macs if a Thunderbolt device is plugged
> > in on boot since Apple's NHI EFI driver sets a number of properties for
> > that device which are leaked on unplug.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Andreas Noever <andreas.noever@gmail.com>
> > Signed-off-by: Lukas Wunner <lukas@wunner.de>
>
> ACK, or I can apply it directly if you want me to do that.
Yes, if you could apply it directly I'd be grateful.
Thanks!
Lukas
next prev parent reply other threads:[~2016-08-30 9:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1469616641.git.lukas@wunner.de>
2016-07-28 0:25 ` [PATCH 1/6] efi: Retrieve Apple device properties Lukas Wunner
2016-07-28 0:25 ` [PATCH 4/6] driver core: Don't leak secondary fwnode on device removal Lukas Wunner
2016-07-28 0:25 ` [PATCH 5/6] efi: Assign Apple device properties Lukas Wunner
2016-07-28 0:25 ` [PATCH 6/6] thunderbolt: Use Device ROM retrieved from EFI Lukas Wunner
2016-07-28 0:25 ` [PATCH 3/6] efi: Add device path parser Lukas Wunner
2016-07-28 0:25 ` [PATCH 2/6] ACPI / bus: Make acpi_get_first_physical_node() public Lukas Wunner
2016-08-04 14:57 ` [PATCH 0/6] Apple device properties Matt Fleming
2016-08-09 13:38 ` Lukas Wunner
2016-08-15 11:54 ` Matt Fleming
2016-08-15 16:13 ` Lukas Wunner
2016-08-18 20:34 ` Matt Fleming
[not found] ` <833d193b8a18b0afe168c515e9e56a857ece4bd1.1469616641.git.lukas@wunner.de>
2016-08-04 15:13 ` [PATCH 1/6] efi: Retrieve " Matt Fleming
[not found] ` <20160804151345.GM3636-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-08-05 11:42 ` Lukas Wunner
2016-08-05 12:06 ` Matt Fleming
[not found] ` <a0edd928ab099682c2cb4c4544c599573144d03a.1469616641.git.lukas@wunner.de>
[not found] ` <a0edd928ab099682c2cb4c4544c599573144d03a.1469616641.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-08-04 15:52 ` [PATCH 5/6] efi: Assign " Matt Fleming
[not found] ` <a0bb3346635e3bd8caf6cf735ceba684e3fde2fa.1469616641.git.lukas@wunner.de>
2016-08-17 0:38 ` [PATCH 2/6] ACPI / bus: Make acpi_get_first_physical_node() public Rafael J. Wysocki
[not found] ` <1821462.QyPXGhZaWJ-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2016-09-12 22:03 ` Rafael J. Wysocki
[not found] ` <ef34b0d31d1fb9bc6a48a07d265fd103527b3f30.1469616641.git.lukas@wunner.de>
2016-08-17 0:38 ` [PATCH 4/6] driver core: Don't leak secondary fwnode on device removal Rafael J. Wysocki
2016-08-30 9:03 ` Lukas Wunner [this message]
2016-09-12 22:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830090325.GA25024@wunner.de \
--to=lukas@wunner.de \
--cc=andreas.noever@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=pierre.morrow@free.fr \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).